Skip to content

[JIT][Autocast] document that scripted autocast context cannot disable eager-enabled autocast #81747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[JIT][Autocast] document that scripted autocast context cannot disable eager-enabled autocast #81747

wants to merge 1 commit into from

Conversation

@davidberard98
Copy link
Contributor

@davidberard98 davidberard98 commented Jul 20, 2022 •
edited
Loading

Stack from ghstack:

JIT autocast mode settings that are modified by a scripted autocast
context are separate from the eager-mode autocast settings that affect
the dispatcher.

@davidberard98
[JIT][Autocast] document that scripted autocast context cannot disabl…
2487890 
…e eager-enabled autocast

JIT autocast mode settings that are modified by a scripted autocast
context are separate from the eager-mode autocast settings that affect
the dispatcher.

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 20, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 2487890 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

davidberard98 added a commit that referenced this pull request Jul 20, 2022
@davidberard98
[JIT][Autocast] document that scripted autocast context cannot disabl…
9e3da22 
…e eager-enabled autocast

JIT autocast mode settings that are modified by a scripted autocast
context are separate from the eager-mode autocast settings that affect
the dispatcher.

ghstack-source-id: 55cb268
Pull Request resolved: #81747
@davidberard98 davidberard98 requested a review from jjsjann123 July 20, 2022 00:46
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jul 20, 2022
jjsjann123
jjsjann123 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@jjsjann123 jjsjann123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the added doc.

@davidberard98
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Matched rule superuser, but PR #81747 was not reviewed yet by any of: zhxchen17, muchulee8, gtarjun, bzinodev, otsneh, ...
Raised by https://github.com/pytorch/pytorch/actions/runs/2707695439

@davidberard98
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @davidberard98.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 22, 2022
@davidberard98 @facebook-github-bot
[JIT][Autocast] document that scripted autocast context cannot disabl…
2d3f07c 
…e eager-enabled autocast (#81747) (#81747)

Summary:
JIT autocast mode settings that are modified by a scripted autocast
context are separate from the eager-mode autocast settings that affect
the dispatcher.

Pull Request resolved: #81747
Approved by: https://github.com/jjsjann123, https://github.com/cpuhrsch

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d3f27f9312e7c41ca77e64b0b33a1626c68de404

Reviewed By: jeanschmidt

Differential Revision: D38066971

Pulled By: jeanschmidt

fbshipit-source-id: ad4142e84631efaf280ea548d1ff565809509cf8
@facebook-github-bot facebook-github-bot deleted the gh/davidberard98/129/head branch July 25, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@jjsjann123 jjsjann123 jjsjann123 approved these changes

Assignees

No one assigned

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@davidberard98 @facebook-github-bot @pytorchmergebot @cpuhrsch @jjsjann123