Skip to content

[JIT] Fix python binding error with empty containers in init.cpp #81786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[JIT] Fix python binding error with empty containers in init.cpp #81786

wants to merge 4 commits into from

Conversation

ttanpcs
Copy link

@ttanpcs ttanpcs commented Jul 20, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

  • toTypeInferredIValue will throw an error when given an empty container because it isn't able to tell what kind of container it is. Thus empty containers are ignored in addArgumentValue/s, overlaps, and is_alias_of.

This was referenced Jul 20, 2022
Closed
Closed
Closed
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 20, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 99c31f4 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jul 20, 2022
davidberard98
davidberard98 reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@davidberard98 davidberard98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also add some tests for these previously-failing cases?

Update on "[JIT] Fix python binding error with empty containers in in…
56ac5b9 
…it.cpp"


- toTypeInferredIValue will throw an error when given an empty container because it isn't able to tell what kind of container it is. Thus empty containers are ignored in addArgumentValue/s, overlaps, and is_alias_of. 


[ghstack-poisoned]
This was referenced Jul 21, 2022
Closed
Closed
@ttanpcs ttanpcs requested a review from davidberard98 July 21, 2022 06:48
This was referenced Jul 21, 2022
Closed
Closed
goldenxuett added 2 commits July 21, 2022 22:33
Update on "[JIT] Fix python binding error with empty containers in in…
a5d70ef 
…it.cpp"


- toTypeInferredIValue will throw an error when given an empty container because it isn't able to tell what kind of container it is. Thus empty containers are ignored in addArgumentValue/s, overlaps, and is_alias_of. 


[ghstack-poisoned]
Update on "[JIT] Fix python binding error with empty containers in in…
99c31f4 
…it.cpp"


- toTypeInferredIValue will throw an error when given an empty container because it isn't able to tell what kind of container it is. Thus empty containers are ignored in addArgumentValue/s, overlaps, and is_alias_of. 


[ghstack-poisoned]
@ttanpcs ttanpcs mentioned this pull request Jul 22, 2022
Closed
@ttanpcs
Copy link
Author

ttanpcs commented Jul 23, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @goldenxuett.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 26, 2022
@facebook-github-bot
[JIT] Fix python binding error with empty containers in init.cpp (#81786
920f7a5 
) (#81786)

Summary:
- toTypeInferredIValue will throw an error when given an empty container because it isn't able to tell what kind of container it is. Thus empty containers are ignored in addArgumentValue/s, overlaps, and is_alias_of.

Pull Request resolved: #81786
Approved by: https://github.com/davidberard98

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d576a7dc97d222ca8db5f8b876ce391866018a9c

Reviewed By: osalpekar

Differential Revision: D38119953

Pulled By: goldenxuett

fbshipit-source-id: 2ab2c68486ca0948dee759ba7859f9003e968f63
@facebook-github-bot facebook-github-bot deleted the gh/goldenxuett/40/head branch July 26, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@davidberard98 davidberard98 davidberard98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ttanpcs @facebook-github-bot @pytorchmergebot @davidberard98