Skip to content

[ao][sparsity] README for data sparsifier lightning callbacks #81813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[ao][sparsity] README for data sparsifier lightning callbacks #81813

wants to merge 3 commits into from

Conversation

@macandro96
Copy link

@macandro96 macandro96 commented Jul 20, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

The README contains instructions on using the lightning callbacks to sparsify the
model during and post training.

Test Plan: None

[ao][sparsity] README for data sparsifier lightning callbacks
3839553 
The README contains instructions on using the lightning callbacks to sparsify the
model during and post training.

Test Plan: None

[ghstack-poisoned]
This was referenced Jul 20, 2022
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 20, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 307795e (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

macandro96 pushed a commit that referenced this pull request Jul 20, 2022
[ao][sparsity] README for data sparsifier lightning callbacks
5186a56 
The README contains instructions on using the lightning callbacks to sparsify the
model during and post training.

Test Plan: None

ghstack-source-id: 7af2b77
Pull Request resolved: #81813
@macandro96 macandro96 requested a review from z-a-f July 20, 2022 21:15
z-a-f
z-a-f approved these changes Jul 21, 2022
View reviewed changes
Copy link

@z-a-f z-a-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add signatures for the functions to let users know what each constructor/method/function is expecting and outputting.

Update on "[ao][sparsity] README for data sparsifier lightning callba…
c3cd58f 
…cks"

The README contains instructions on using the lightning callbacks to sparsify the
model during and post training.

Test Plan: None

[ghstack-poisoned]
macandro96 pushed a commit that referenced this pull request Jul 26, 2022
[ao][sparsity] README for data sparsifier lightning callbacks
ae550ce 
The README contains instructions on using the lightning callbacks to sparsify the
model during and post training.

Test Plan: None

ghstack-source-id: 5da9bd5
Pull Request resolved: #81813
Update on "[ao][sparsity] README for data sparsifier lightning callba…
307795e 
…cks"

The README contains instructions on using the lightning callbacks to sparsify the
model during and post training.

Test Plan: None

[ghstack-poisoned]
macandro96 pushed a commit that referenced this pull request Jul 26, 2022
[ao][sparsity] README for data sparsifier lightning callbacks
5207eb3 
The README contains instructions on using the lightning callbacks to sparsify the
model during and post training.

Test Plan: None

ghstack-source-id: a72ad3d
Pull Request resolved: #81813
@macandro96
Copy link
Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @macandro96.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 28, 2022
@facebook-github-bot
[ao][sparsity] README for data sparsifier lightning callbacks (#81813) (
641a849 
#81813)

Summary:
The README contains instructions on using the lightning callbacks to sparsify the
model during and post training.

Pull Request resolved: #81813
Approved by: https://github.com/z-a-f

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/7af2baffce296371e39ca2761c63497bc232f198

Test plan from GitHub:
None

Reviewed By: osalpekar

Differential Revision: D38226991

Pulled By: macandro96

fbshipit-source-id: 59770751b4b344853d9d3a059da23b3d0f2d3962
@facebook-github-bot facebook-github-bot deleted the gh/macandro96/27/head branch July 31, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@z-a-f z-a-f z-a-f approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@macandro96 @facebook-github-bot @pytorchmergebot @z-a-f