[composite compliance] prod #81969

kshitij12345 · 2022-07-22T08:06:24Z

Also fixes #82644

For CompositeCompliance, we can't use item to choose a special fast-path when Tensor is a Subclass. Instead we always dispatch to the slower but safer implementation.

@diff-train-skip-merge

facebook-github-bot · 2022-07-22T08:06:30Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/81969
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit ce42074 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

…composite-compliance/prod

kshitij12345 · 2022-08-04T12:54:04Z

Ping @zou3519

torch/csrc/autograd/FunctionsManual.cpp

…composite-compliance/prod

pytorch-bot · 2022-09-14T15:26:24Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/81969

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit f94152e:

The following jobs have failed:

linux-bionic-cuda11.6-py3.10-gcc7 / test (distributed, 1, 3, linux.8xlarge.nvidia.gpu)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

functorch/test/test_ops.py

zou3519

We should not regress support for input shapes like (3, 0). To do that, I think just calling grad * (result / input).conj(); in the zero-numel case works. Other than that, this LGTM, with some minor comments

zou3519

Thanks!

kshitij12345 · 2022-09-19T21:50:26Z

@pytorchbot merge

pytorchmergebot · 2022-09-19T21:52:09Z

@pytorchbot successfully started a merge job. Check the current status here and land check progress here.
The merge job was triggered with the land checks (-l) flag. If you did not specify this flag yourself, you are likely enrolled in the land checks rollout. This means that your change will be merged once all checks on your PR and the land checks have passed (ETA 4 Hours). If you need to coordinate lands between different changes and cannot risk a land race, please add the ciflow/trunk label to your PR and wait for signal to complete, and then land your changes in proper order. Having trunk, pull, and Lint pre-run on a PR will bypass land checks and the ETA should be immediate. If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-09-19T23:02:35Z

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

pull

Dig deeper by viewing the failures on hud

If you believe this is an error, you can use the old behavior with @pytorchbot merge -g (optionally with the ciflow/trunk to get land checks) or use @pytorchbot merge -f "some reason here". For more information, see the bot wiki.

Please reach out to the PyTorch DevX Team with feedback or questions!

Details for Dev Infra team

Raised by workflow job

kshitij12345 · 2022-09-20T08:02:13Z

@pytorchbot merge -f "CI failure was flaky"

pytorchmergebot · 2022-09-20T08:03:32Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

github-actions · 2022-09-20T08:04:20Z

Hey @kshitij12345.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot · 2022-09-20T22:16:45Z

@dagitses has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

dagitses · 2022-09-21T17:58:06Z

@pytorchbot revert --message='a PR this is based on got reverted, rebase and reland' --classification=ghfirst

pytorchmergebot · 2022-09-21T18:01:00Z

@pytorchbot successfully started a revert job. Check the current status here.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-09-21T18:01:04Z

Reverting PR 81969 failed

Reason: Command git -C /home/runner/work/pytorch/pytorch revert --no-edit a4dca9822dfabcdbd1b36a12c013764f2af87613 returned non-zero exit code 1

Auto-merging functorch/test/test_ops.py
CONFLICT (content): Merge conflict in functorch/test/test_ops.py
Auto-merging torch/csrc/autograd/FunctionsManual.cpp
CONFLICT (content): Merge conflict in torch/csrc/autograd/FunctionsManual.cpp
Auto-merging torch/testing/_internal/common_methods_invocations.py
Auto-merging torch/testing/_internal/opinfo/definitions/_masked.py
error: could not revert a4dca9822d... [composite compliance] prod (#81969)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git revert --continue".
hint: You can instead skip this commit with "git revert --skip".
hint: To abort and get back to the state before "git revert",
hint: run "git revert --abort".

Details for Dev Infra team

Raised by workflow job

dagitses · 2022-09-21T18:09:14Z

@pytorchbot revert --message='a PR this is based on got reverted, rebase and reland' --classification=ghfirst

dagitses · 2022-09-21T18:10:06Z

Might as well also include #85400 in the stack when you reland this.

pytorchmergebot · 2022-09-21T18:10:35Z

@pytorchbot successfully started a revert job. Check the current status here.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-09-21T18:10:39Z

Reverting PR 81969 failed

Reason: Command git -C /home/runner/work/pytorch/pytorch revert --no-edit a4dca9822dfabcdbd1b36a12c013764f2af87613 returned non-zero exit code 1

Auto-merging torch/csrc/autograd/FunctionsManual.cpp
CONFLICT (content): Merge conflict in torch/csrc/autograd/FunctionsManual.cpp
Auto-merging torch/testing/_internal/common_methods_invocations.py
error: could not revert a4dca9822d... [composite compliance] prod (#81969)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git revert --continue".
hint: You can instead skip this commit with "git revert --skip".
hint: To abort and get back to the state before "git revert",
hint: run "git revert --abort".

Details for Dev Infra team

Raised by workflow job

kshitij12345 · 2022-09-21T19:01:41Z

@dagitses is there anything to be done from my end?

Ref: #69991 Also fixes #82644 (fix similar to #81617) For CompositeCompliance, we can't use `item` to choose a special fast-path when Tensor is a Subclass. Instead we always dispatch to the slower but safer implementation. Pull Request resolved: #81969 Approved by: https://github.com/zou3519

This reverts commit a4dca98.

[composite compliance] prod

b7121dc

facebook-github-bot added the cla signed label Jul 22, 2022

pytorchbot added the open source label Jul 22, 2022

kshitij12345 added 4 commits July 28, 2022 06:00

Merge branch 'master' of https://github.com/pytorch/pytorch into fix/…

81cf577

…composite-compliance/prod

Merge branch 'master' of https://github.com/pytorch/pytorch into fix/…

2e58bf2

…composite-compliance/prod

fixes

38e90ca

update the formula

ce42074

kshitij12345 requested a review from zou3519 August 2, 2022 15:53

kshitij12345 marked this pull request as ready for review August 2, 2022 15:53

kshitij12345 requested review from albanD, mruberry, ngimel and soulitzer as code owners August 2, 2022 15:53

kshitij12345 removed request for albanD, mruberry, ngimel and soulitzer August 2, 2022 15:54

albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 3, 2022

zou3519 reviewed Aug 4, 2022

View reviewed changes

torch/csrc/autograd/FunctionsManual.cpp Outdated Show resolved Hide resolved

zou3519 reviewed Aug 4, 2022

View reviewed changes

torch/csrc/autograd/FunctionsManual.cpp Outdated Show resolved Hide resolved

Merge branch 'master' of https://github.com/pytorch/pytorch into fix/…

fb90a9d

…composite-compliance/prod

kshitij12345 added 4 commits September 14, 2022 15:29

address review

a58d73f

update xfails and skips

4ab41bf

update the fix

1c238fd

remove stray include

14083fe

kshitij12345 commented Sep 18, 2022

View reviewed changes

functorch/test/test_ops.py Outdated Show resolved Hide resolved

Merge branch 'pytorch:master' into fix/composite-compliance/prod

79e3828

zou3519 reviewed Sep 19, 2022

View reviewed changes

functorch/test/test_ops.py Outdated Show resolved Hide resolved

zou3519 reviewed Sep 19, 2022

View reviewed changes

kshitij12345 added 2 commits September 19, 2022 21:04

address review

2f88f55

add new sample to prod

f94152e

zou3519 approved these changes Sep 19, 2022

View reviewed changes

pytorchmergebot added the Merged label Sep 20, 2022

pytorchmergebot closed this in a4dca98 Sep 20, 2022

dagitses reopened this Sep 20, 2022

dagitses closed this Sep 20, 2022

mehtanirav added a commit that referenced this pull request Oct 4, 2022

Revert "[composite compliance] prod (#81969)"

23ff979

This reverts commit a4dca98.

[composite compliance] prod #81969

[composite compliance] prod #81969

Uh oh!

Conversation

kshitij12345 commented Jul 22, 2022 • edited by weiwangmeta Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jul 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

✅ No Failures (0 Pending)

Uh oh!

kshitij12345 commented Aug 4, 2022

Uh oh!

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/81969

❌ 1 Failures

Uh oh!

Uh oh!

Uh oh!

zou3519 left a comment

Choose a reason for hiding this comment

Uh oh!

zou3519 left a comment

Choose a reason for hiding this comment

Uh oh!

kshitij12345 commented Sep 19, 2022

Uh oh!

pytorchmergebot commented Sep 19, 2022

Uh oh!

pytorchmergebot commented Sep 19, 2022

Merge failed

Uh oh!

kshitij12345 commented Sep 20, 2022

Uh oh!

pytorchmergebot commented Sep 20, 2022

Uh oh!

github-actions bot commented Sep 20, 2022

Uh oh!

facebook-github-bot commented Sep 20, 2022

Uh oh!

dagitses commented Sep 21, 2022

Uh oh!

pytorchmergebot commented Sep 21, 2022

Uh oh!

pytorchmergebot commented Sep 21, 2022

Reverting PR 81969 failed

Uh oh!

dagitses commented Sep 21, 2022

Uh oh!

dagitses commented Sep 21, 2022

Uh oh!

pytorchmergebot commented Sep 21, 2022

Uh oh!

pytorchmergebot commented Sep 21, 2022

Reverting PR 81969 failed

Uh oh!

kshitij12345 commented Sep 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

kshitij12345 commented Jul 22, 2022 •

edited by weiwangmeta

Loading

facebook-github-bot commented Jul 22, 2022 •

edited

Loading

pytorch-bot bot commented Sep 14, 2022 •

edited

Loading