[ao] Update DynamicStatic Detector to account for Conv #81972
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This updates the DynamicStatic Detector to also provide insight into whether Conv layers should use dynamic or static quantization. Before, this was not included because as of now, Dynamic quantization is not supported for Conv layers, but this adds a check for Conv layers and if dynamic is recommended, it will also give a disclaimer that it is not currently supported but will be in the future. Test Plan: python test/test_quantization.py TestFxModelReportDetectDynamicStatic Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful links
✅ No Failures (0 Pending)As of commit b80ebdd (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jul 22, 2022
Summary: This updates the DynamicStatic Detector to also provide insight into whether Conv layers should use dynamic or static quantization. Before, this was not included because as of now, Dynamic quantization is not supported for Conv layers, but this adds a check for Conv layers and if dynamic is recommended, it will also give a disclaimer that it is not currently supported but will be in the future. Test Plan: python test/test_quantization.py TestFxModelReportDetectDynamicStatic Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
reviewed
Jul 22, 2022
jerryzh168
reviewed
Jul 22, 2022
jerryzh168
approved these changes
Jul 22, 2022
Summary: This updates the DynamicStatic Detector to also provide insight into whether Conv layers should use dynamic or static quantization. Before, this was not included because as of now, Dynamic quantization is not supported for Conv layers, but this adds a check for Conv layers and if dynamic is recommended, it will also give a disclaimer that it is not currently supported but will be in the future. Test Plan: python test/test_quantization.py TestFxModelReportDetectDynamicStatic Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
vspenubarthi
added
release notes: quantization
|
@pytorchbot merge -g |
|
@pytorchbot successfully started a merge job. Check the current status here |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 26, 2022
Summary: This updates the DynamicStatic Detector to also provide insight into whether Conv layers should use dynamic or static quantization. Before, this was not included because as of now, Dynamic quantization is not supported for Conv layers, but this adds a check for Conv layers and if dynamic is recommended, it will also give a disclaimer that it is not currently supported but will be in the future. Pull Request resolved: #81972 Approved by: https://github.com/jerryzh168 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/75aab6540e24e05f52dd8f69aca9674dc1eb9a2c Test plan from GitHub: python test/test_quantization.py TestFxModelReportDetectDynamicStatic Reviewed By: osalpekar Differential Revision: D38119634 Pulled By: vspenubarthi fbshipit-source-id: 53056b258882b387f1dec7ddbc45185e6bc26747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: This updates the DynamicStatic Detector to also provide insight
into whether Conv layers should use dynamic or static quantization.
Before, this was not included because as of now, Dynamic quantization is
not supported for Conv layers, but this adds a check for Conv layers and
if dynamic is recommended, it will also give a disclaimer that it is not
currently supported but will be in the future.
Test Plan: python test/test_quantization.py TestFxModelReportDetectDynamicStatic
Reviewers:
Subscribers:
Tasks:
Tags: