Modify APoT dequantize method #82126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 109d69e (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
[ghstack-poisoned]
HDCharles
suggested changes
Jul 25, 2022
### Summary Modify APoT dequantize method to correctly add dequantized values to result numpy array ### Test Plan Run unit tests with: `python test/quantization/core/experimental/test_quantizer.py` [ghstack-poisoned]
HDCharles
approved these changes
Jul 26, 2022
### Summary Modify APoT dequantize method to correctly add dequantized values to result numpy array ### Test Plan Run unit tests with: `python test/quantization/core/experimental/test_quantizer.py` [ghstack-poisoned]
asl3
added
release notes: quantization
|
@pytorchbot merge -g |
|
@pytorchbot successfully started a merge job. Check the current status here |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 27, 2022
Summary: ### Summary Modify APoT dequantize method to correctly add dequantized values to result numpy array and retain original tensor dimensions ### Test Plan Run unit tests with: `python test/quantization/core/experimental/test_quantizer.py` Pull Request resolved: #82126 Approved by: https://github.com/HDCharles Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/a01fb5392fbc45d61eddb9d3dd91d82637f06016 Reviewed By: osalpekar Differential Revision: D38181804 Pulled By: asl3 fbshipit-source-id: e7343e1acd0e29e8262ca22d1f2144f4c5d79582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary
Modify APoT dequantize method to correctly add dequantized values to result numpy array and retain original tensor dimensions
Test Plan
Run unit tests with:
python test/quantization/core/experimental/test_quantizer.py