[ao][sparsity] Bug Fix: Retain mask and config while replacing data in data sparsifier #82129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n data sparsifier Bug: The config and mask were being recreated while replacing data on the data sparsifier. Fix: Introduced an argument `use_old_mask` which when set `True` uses the old mask. If new config is not specified, the data sparsifier by default uses the old config with the new data. Also, added unit tests to check this bug. Test Plan: ```python test/test_ao_sparsity.py TestBaseDataSparsifier``` [ghstack-poisoned]
🔗 Helpful links
✅ No Failures (0 Pending)As of commit f904b70 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jul 25, 2022
…cing data in data sparsifier" Bug: The config and mask were being recreated while replacing data on the data sparsifier. Fix: Introduced an argument `use_old_mask` which when set `True` uses the old mask. If new config is not specified, the data sparsifier by default uses the old config with the new data. Also, added unit tests to check this bug. Test Plan: ```python test/test_ao_sparsity.py TestBaseDataSparsifier``` [ghstack-poisoned]
…cing data in data sparsifier" Bug: The config and mask were being recreated while replacing data on the data sparsifier. Fix: Introduced an argument `use_old_mask` which when set `True` uses the old mask. If new config is not specified, the data sparsifier by default uses the old config with the new data. Also, added unit tests to check this bug. Test Plan: ```python test/test_ao_sparsity.py TestBaseDataSparsifier``` [ghstack-poisoned]
z-a-f
approved these changes
Jul 26, 2022
torch/ao/sparsity/_experimental/data_sparsifier/base_data_sparsifier.py
Outdated
Show resolved
Hide resolved
added 2 commits
July 26, 2022 21:29
…cing data in data sparsifier" Bug: The config and mask were being recreated while replacing data on the data sparsifier. Fix: Introduced an argument `use_old_mask` which when set `True` uses the old mask. If new config is not specified, the data sparsifier by default uses the old config with the new data. Also, added unit tests to check this bug. Test Plan: ```python test/test_ao_sparsity.py TestBaseDataSparsifier``` [ghstack-poisoned]
…cing data in data sparsifier" Bug: The config and mask were being recreated while replacing data on the data sparsifier. Fix: Introduced an argument `reuse_mask` which when set `True` uses the old mask. If new config is not specified, the data sparsifier by default uses the old config with the new data. Also, added unit tests to check this bug. Test Plan: ```python test/test_ao_sparsity.py TestBaseDataSparsifier``` [ghstack-poisoned]
|
@pytorchbot merge -g |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Hey @macandro96. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 28, 2022
…data sparsifier (#82129) (#82129) Summary: Bug: The config and mask were being recreated while replacing data on the data sparsifier. Fix: Introduced an argument `reuse_mask` which when set `True` uses the old mask. If new config is not specified, the data sparsifier by default uses the old config with the new data. Also, added unit tests to check this bug. Pull Request resolved: #82129 Approved by: https://github.com/z-a-f Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/7391dec96ab9f52b841973149922ff39ada489ff Test plan from GitHub: ```python test/test_ao_sparsity.py TestBaseDataSparsifier``` Reviewed By: osalpekar Differential Revision: D38226946 Pulled By: macandro96 fbshipit-source-id: 21974cd0e4e53eb860fecd5319c4dea238348657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Bug: The config and mask were being recreated while replacing data on the data sparsifier.
Fix: Introduced an argument
reuse_maskwhich when setTrueuses the old mask. If new config is notspecified, the data sparsifier by default uses the old config with the new data.
Also, added unit tests to check this bug.
Test Plan:
python test/test_ao_sparsity.py TestBaseDataSparsifier