Skip to content

Format torch/onnx with ufmt #82137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Format torch/onnx with ufmt #82137

wants to merge 3 commits into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Jul 25, 2022

This is the last batch for the new ufmt (black + usort) linter. After this, black linter can finally be replaced. The previous PR to format ONNX tests was #81335

huydhn added 3 commits July 25, 2022 10:40
@huydhn
Reformat torch onnx with ufmt
65cd4b6 
This is the last batch. After this, black linter can finally be replaced
by ufmt (black + usort)
@huydhn
Format some more files
e8f55ef
@huydhn
Not sorting lexicographically for symbolic_opset
c4b5418
@huydhn huydhn requested a review from a team July 25, 2022 18:04
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 25, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit c4b5418 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@huydhn huydhn changed the title Reformat torch/onnx with ufmt Format torch/onnx with ufmt Jul 25, 2022
@huydhn
Copy link
Contributor Author

huydhn commented Jul 25, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @huydhn.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 27, 2022
@huydhn @facebook-github-bot
Format torch/onnx with ufmt (#82137) (#82137)
bece9a0 
Summary:
This is the last batch for the new ufmt (black + usort) linter. After this, black linter can finally be replaced. The previous PR to format ONNX tests was #81335

Pull Request resolved: #82137
Approved by: https://github.com/kit1980, https://github.com/AllenTiTaiWang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/6ea422dd0be544140e3cc2bb8546159d103a4b0d

Reviewed By: osalpekar

Differential Revision: D38142973

Pulled By: huydhn

fbshipit-source-id: 69699cef00053f5eb3f6d93b2645dbdf07e1fce0
@justinchuby justinchuby mentioned this pull request Jul 27, 2022
Closed
justinchuby pushed a commit to justinchuby/pytorch that referenced this pull request Jul 27, 2022
@huydhn @justinchuby
Format torch/onnx with ufmt (pytorch#82137)
960767a 
This is the last batch for the new ufmt (black + usort) linter. After this, black linter can finally be replaced. The previous PR to format ONNX tests was pytorch#81335
Pull Request resolved: pytorch#82137
Approved by: https://github.com/kit1980, https://github.com/AllenTiTaiWang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

@BowenBao BowenBao Awaiting requested review from BowenBao

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

+1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@huydhn @facebook-github-bot @pytorchmergebot @kit1980 @titaiwangms