Skip to content

Change SymIntNode into an intrusive pointer #82432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Change SymIntNode into an intrusive pointer #82432

wants to merge 3 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Jul 28, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

This will make the pointer type a single word, which is important
for packing it into an int64_t

Signed-off-by: Edward Z. Yang ezyang@fb.com

@ezyang
Change SymIntNode into an intrusive pointer
0344998 
This will make the pointer type a single word, which is important
for packing it into an int64_t

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 28, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit b37713c (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jul 28, 2022
@ezyang
Update on "Change SymIntNode into an intrusive pointer"
b5f9d9f 
This will make the pointer type a single word, which is important
for packing it into an int64_t

Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@ezyang ezyang requested a review from Krovatkin July 28, 2022 23:10
@ezyang
Update on "Change SymIntNode into an intrusive pointer"
b37713c 
This will make the pointer type a single word, which is important
for packing it into an int64_t

Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Jul 28, 2022
@ezyang
Change SymIntNode into an intrusive pointer
2e9d368 
This will make the pointer type a single word, which is important
for packing it into an int64_t

Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: 9a7934f
Pull Request resolved: #82432
This was referenced Jul 29, 2022
Closed
Closed
Closed
albanD
albanD approved these changes Jul 29, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Krovatkin
Krovatkin approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@Krovatkin Krovatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ezyang
Copy link
Contributor Author

ezyang commented Jul 29, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@ezyang
Copy link
Contributor Author

ezyang commented Jul 29, 2022

@pytorchbot revert -m "segfaults on test but not caught in CI" -c nosignal

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

@ezyang your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Jul 29, 2022
@pytorchmergebot
Revert "Change SymIntNode into an intrusive pointer (#82432)"
3b9cbb1 
This reverts commit 7be44f8.

Reverted #82432 on behalf of https://github.com/ezyang due to segfaults on test but not caught in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

+1 more reviewer

@Krovatkin Krovatkin Krovatkin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ezyang @facebook-github-bot @pytorchmergebot @Krovatkin @albanD