Skip to content

Fix issue 38095 TODOs in test_jit #82629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Add extra debug info for the super common "index out of bounds" error.
wants to merge 2 commits into from
Closed

Fix issue 38095 TODOs in test_jit #82629

wants to merge 2 commits into from

Conversation

@kit1980
Copy link
Contributor

@kit1980 kit1980 commented Aug 2, 2022 •
edited
Loading

Fix TODOs related to #38095 in test_jit.py

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 2, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results here

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 78b167b:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kit1980 kit1980 requested a review from VitalyFedyunin August 2, 2022 00:30
@kit1980 kit1980 added better-engineering Relatively self-contained tasks for better engineering contributors todo-elimination labels Aug 2, 2022
@kit1980 kit1980 marked this pull request as ready for review August 2, 2022 02:38
@kit1980 kit1980 requested a review from a team August 2, 2022 06:18
@kit1980
Copy link
Contributor Author

kit1980 commented Aug 3, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge and created land time checks. See merge status here and land check progress here.

pytorchmergebot pushed a commit that referenced this pull request Aug 3, 2022
@kit1980 @pytorchmergebot
Fix issue 38095 TODOs in test_jit (#82629)
3ac399d 
Fix TODOs related to #38095 in test_jit.py
Pull Request resolved: #82629
Approved by: https://github.com/clee2000
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Hey @kit1980.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Aug 4, 2022
@kit1980 @facebook-github-bot
Fix issue 38095 TODOs in test_jit (#82629) (#82629)
c27b395 
Summary:
Fix TODOs related to #38095 in test_jit.py

Pull Request resolved: #82629
Approved by: https://github.com/clee2000, https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/58d1cf7e39ec8e2eec5150e2d227e9a3da9f9bb6

Reviewed By: malfet, mehtanirav

Differential Revision: D38425167

Pulled By: kit1980

fbshipit-source-id: 39625cc8a4352cb169001c4fe3217c4166aef548
@github-actions github-actions bot deleted the sdym/38095-test_jit.py branch February 18, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@clee2000 clee2000 clee2000 approved these changes

@VitalyFedyunin VitalyFedyunin Awaiting requested review from VitalyFedyunin

Assignees

No one assigned

Labels

better-engineering Relatively self-contained tasks for better engineering contributors cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kit1980 @pytorchmergebot @malfet @clee2000 @facebook-github-bot