-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Support variable arguments for refs.reshape and refs.view #82651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful links
❌ 2 New Failures, 1 Base FailuresAs of commit 6c55d44 (more details on the Dr. CI page): Expand to see more
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
|
@pytorchbot merge -g |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser |
|
@pytorchbot merge -f "windows failures are on trunk" |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Hey @IvanYashchuk. |
…82651) Summary: ### Description In PyTorch, it's possible to pass unpacked shape to Tensor.view/reshape, and when this call is translated to use refs it caused an error. Now `refs.reshape` and `refs.view` support passing variable arguments for the shape. ### Testing Added a simple test `test_reshape_view_method` that compares Tensor.reshape/view to torch._refs.reshape/view result. Pull Request resolved: #82651 Approved by: https://github.com/ngimel Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d693478789c724c6a74c6b28db236e01db97edf6 Reviewed By: kit1980 Differential Revision: D38395071 fbshipit-source-id: 78ed92ed925c07b781ce61919847aa3aec2488fd
Description
In PyTorch, it's possible to pass unpacked shape to Tensor.view/reshape, and when this call is translated to use refs it caused an error.
Now
refs.reshapeandrefs.viewsupport passing variable arguments for the shape.Testing
Added a simple test
test_reshape_view_methodthat compares Tensor.reshape/view to torch._refs.reshape/view result.