Skip to content

[Small] Remove using c10d::ProcessGroup directive from c10d test #82681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Small] Remove using c10d::ProcessGroup directive from c10d test #82681

wants to merge 2 commits into from

Conversation

@H-Huang
Copy link
Member

@H-Huang H-Huang commented Aug 2, 2022 •
edited by pytorchmergebot
Loading

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 2, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (5 Pending)

As of commit 6651728 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Aug 2, 2022
H-Huang added a commit that referenced this pull request Aug 2, 2022
@H-Huang
[Small] Remove using c10d::ProcessGroup directive from c10d test
8c41fb2 
ghstack-source-id: 23a00a9
Pull Request resolved: #82681
@H-Huang
Copy link
Member Author

H-Huang commented Aug 3, 2022

@pytorchbot rebase -s

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/H-Huang/68/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/82681)

pytorchmergebot pushed a commit that referenced this pull request Aug 3, 2022
@H-Huang
[Small] Remove using c10d::ProcessGroup directive from c10d test
f6a2ff4 
ghstack-source-id: c488413
Pull Request resolved: #82681
awgu
awgu approved these changes Aug 3, 2022
View reviewed changes
Copy link
Collaborator

@awgu awgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@H-Huang
Copy link
Member Author

H-Huang commented Aug 3, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Hey @H-Huang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@H-Huang H-Huang added release notes: distributed (c10d) release notes category topic: not user facing topic category labels Aug 3, 2022
facebook-github-bot pushed a commit that referenced this pull request Aug 4, 2022
@H-Huang @facebook-github-bot
[Small] Remove using c10d::ProcessGroup directive from c10d test (#82681
ed1e960 
) (#82681)

Summary:
Pull Request resolved: #82681
Approved by: https://github.com/awgu

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/9d228fe517a0db86e79b5d9ab20ac153f887b11a

Reviewed By: kit1980

Differential Revision: D38395372

Pulled By: H-Huang

fbshipit-source-id: d4ef2d24769955234795748389a136002d39bbec
@facebook-github-bot facebook-github-bot deleted the gh/H-Huang/68/head branch August 7, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awgu awgu awgu approved these changes

Assignees

No one assigned

Labels

cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@H-Huang @facebook-github-bot @pytorchmergebot @awgu