Skip to content

Conversation

@zrphercule
Copy link
Contributor

Summary:
This diff creates a aten Triton path along with a dummy aten scaled dot attention operator

Pull Request resolved: #82509

Test Plan: CI, since the operator is dummy (not to-be registered in python), there is no way to test its correctness in this diff

Reviewed By: erichan1, ngimel

Differential Revision: D37897092

Pulled By: zrphercule

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 3, 2022

🔗 Helpful links

✅ No Failures (4 Pending)

As of commit 8f89d58 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37897092

@zrphercule zrphercule requested a review from erichan1 August 3, 2022 22:00
Copy link
Contributor

@erichan1 erichan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's get Triton in. We really should refactor most of the BetterTransformer MHA though so we don't have to copy all over the place. But that's something for another day.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37897092

@zrphercule
Copy link
Contributor Author

@pytorchbot merge -g

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37897092

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2792781352

@zrphercule
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2793362887

@facebook-github-bot
Copy link
Contributor

@zrphercule has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

…h#82509)

Summary:
This diff creates a aten Triton path along with a dummy aten scaled dot attention operator

Pull Request resolved: pytorch#82509

Pull Request resolved: pytorch#82758

Test Plan: CI, since the operator is dummy (not to-be registered in python), there is no way to test its correctness in this diff

Reviewed By: erichan1, ngimel

Pulled By:
zrphercule
zrphercule

Differential Revision: D37897092

fbshipit-source-id: 037c98afdc8a67364cf077d983e23b159841c234
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D37897092

@zrphercule
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

facebook-github-bot pushed a commit that referenced this pull request Aug 4, 2022
Summary:
This diff creates a aten Triton path along with a dummy aten scaled dot attention operator

Pull Request resolved: #82509
#82758
Approved by: https://github.com/erichan1

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/dd838cee0df98836bc14a9d7976c097f12f8d438

Test plan from GitHub:
CI, since the operator is dummy (not to-be registered in python), there is no way to test its correctness in this diff

Reviewed By: kit1980, erichan1, ngimel

Differential Revision: D37897092

Pulled By: zrphercule

fbshipit-source-id: 7fb2d4f58079d4db4dc4dc2ef7a2e6feb1871d8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants