[functorch] refactor get_fallback_and_vmap_exhaustive #82897
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors get_fallback_and_vmap_exhaustive into two helper functions, `generate_vmap_inputs` and `compute_quantities_for_vmap_test`. The former is responsible for generating in_dims and the batched inputs; the latter is responsible for computing vmap(blah) and the fallback. The rationale for the refactor is that I want to use these pieces separately in in-place vmap testing, which is coming soon. Test Plan: - run tests [ghstack-poisoned]
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 566acf8 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Aug 5, 2022
Chillee
approved these changes
Aug 6, 2022
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 8, 2022
This PR refactors get_fallback_and_vmap_exhaustive into two helper functions, `generate_vmap_inputs` and `compute_quantities_for_vmap_test`. The former is responsible for generating in_dims and the batched inputs; the latter is responsible for computing vmap(blah) and the fallback. The rationale for the refactor is that I want to use these pieces separately in in-place vmap testing, which is coming soon. Test Plan: - run tests Pull Request resolved: #82897 Approved by: https://github.com/Chillee
facebook-github-bot
pushed a commit
to pytorch/functorch
that referenced
this pull request
Aug 9, 2022
Summary: This PR refactors get_fallback_and_vmap_exhaustive into two helper functions, `generate_vmap_inputs` and `compute_quantities_for_vmap_test`. The former is responsible for generating in_dims and the batched inputs; the latter is responsible for computing vmap(blah) and the fallback. The rationale for the refactor is that I want to use these pieces separately in in-place vmap testing, which is coming soon. X-link: pytorch/pytorch#82897 Approved by: https://github.com/Chillee Reviewed By: kit1980 Differential Revision: D38505902 Pulled By: zou3519 fbshipit-source-id: 3897ce36f954682469769d9ece0ecfc0e72b7545
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
Summary: This PR refactors get_fallback_and_vmap_exhaustive into two helper functions, `generate_vmap_inputs` and `compute_quantities_for_vmap_test`. The former is responsible for generating in_dims and the batched inputs; the latter is responsible for computing vmap(blah) and the fallback. The rationale for the refactor is that I want to use these pieces separately in in-place vmap testing, which is coming soon. Pull Request resolved: #82897 Approved by: https://github.com/Chillee Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/7c993d7f0358ab8eff3c0e0f9d9d2374678b6e70 Test plan from GitHub: - run tests Reviewed By: kit1980 Differential Revision: D38505902 Pulled By: zou3519 fbshipit-source-id: 3897ce36f954682469769d9ece0ecfc0e72b7545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
import functorch#82905transpose_,t_and aliases thereof batching rules #82903This PR refactors get_fallback_and_vmap_exhaustive into two helper
functions,
generate_vmap_inputsandcompute_quantities_for_vmap_test. The former is responsible forgenerating in_dims and the batched inputs; the latter is responsible for
computing vmap(blah) and the fallback.
The rationale for the refactor is that I want to use these pieces
separately in in-place vmap testing, which is coming soon.
Test Plan: