Skip to content

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Aug 10, 2022

Miniconda3 has been installed in the Windows AMI (ami-04a25a5bcec5bc2bf) with all the build and test dependencies in https://github.com/fairinternal/pytorch-gha-infra/pull/41

Testing

All Windows build and test jobs pass on canary https://github.com/pytorch/pytorch-canary/pull/134

Issue

#83003

@huydhn huydhn requested review from a team and atalman August 10, 2022 18:15
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 10, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/83188

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b2e45f5:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn huydhn added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 10, 2022
@huydhn
Copy link
Contributor Author

huydhn commented Aug 12, 2022

cc @atalman

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huydhn
Copy link
Contributor Author

huydhn commented Aug 12, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

Hey @huydhn.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Aug 14, 2022
Summary:
Miniconda3 has been installed in the Windows AMI (ami-04a25a5bcec5bc2bf) with all the build and test dependencies in meta-pytorch/pytorch-gha-infra#41

### Testing
All Windows build and test jobs pass on canary pytorch/pytorch-canary#134

### Issue
#83003

Pull Request resolved: #83188
Approved by: https://github.com/atalman

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/8598a8662b578bf0197dc40d4a30371e2be09289

Reviewed By: atalman

Differential Revision: D38671284

Pulled By: huydhn

fbshipit-source-id: efd19859f904c4345a9e8f4844295d598e2f621a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants