fix quantization/core/test_docs for Buck2 #83341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

dagitses wants to merge 1 commit into pytorch:master from dagitses:export-D38662169

Collaborator

dagitses commented Aug 12, 2022

Summary:
We extract the test to its own target, fixing the relative path to the
quantization docs. This allows us to find the docs with a more simple
implementation.

Test Plan: Tested locally with buck1 and buck2.

Differential Revision: D38662169

pytorch-bot bot commented Aug 12, 2022 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/83341

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c4eaed3:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added cla signed fb-exported labels

Contributor

facebook-github-bot commented Aug 12, 2022

This pull request was exported from Phabricator. Differential Revision: D38662169

5 similar comments

Contributor

facebook-github-bot commented Aug 13, 2022

This pull request was exported from Phabricator. Differential Revision: D38662169

Contributor

facebook-github-bot commented Aug 13, 2022

This pull request was exported from Phabricator. Differential Revision: D38662169

Contributor

facebook-github-bot commented Aug 13, 2022

This pull request was exported from Phabricator. Differential Revision: D38662169

Contributor

facebook-github-bot commented Aug 17, 2022

This pull request was exported from Phabricator. Differential Revision: D38662169

Contributor

facebook-github-bot commented Aug 17, 2022

This pull request was exported from Phabricator. Differential Revision: D38662169


          fix quantization/core/test_docs for Buck2 (#83341)

c4eaed3

Summary:
Pull Request resolved: #83341

We extract the test to its own target, fixing the relative path to the
quantization docs. This allows us to find the docs with a more simple
implementation.

Test Plan: Tested locally with buck1 and buck2.

Reviewed By: r-barnes

Differential Revision: D38662169

fbshipit-source-id: ab23f0b8c06ef5249bbb6c0c43f919c554409656

Contributor

facebook-github-bot commented Aug 17, 2022

This pull request was exported from Phabricator. Differential Revision: D38662169

huydhn approved these changes

View reviewed changes

seemethere approved these changes

View reviewed changes

ZainRizvi approved these changes

View reviewed changes

Contributor

ZainRizvi left a comment

Just one potential bug. Otherwise looks great.

test/quantization/core/test_docs.py

    
                          # no longer passing when file not found

                          raise FileNotFoundError("could not find {}".format(path_from_pytorch))

                          core_dir = Path(__file__).parent

                          assert core_dir.match("test/quantization/core/"), (

Contributor

ZainRizvi Aug 17, 2022

Do you want this assert to also fail if test_docs.py is moved to a subdirectory of test/quantization/core/?

Contributor

facebook-github-bot commented Aug 18, 2022

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

Collaborator

pytorchmergebot commented Aug 18, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot added the Merged label

pytorchmergebot closed this in

3f612b5

Contributor

github-actions bot commented Aug 18, 2022

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request


          fix quantization/core/test_docs for Buck2 (#83341)

4bbdcc1

Summary:
Pull Request resolved: #83341

We extract the test to its own target, fixing the relative path to the
quantization docs. This allows us to find the docs with a more simple
implementation.

Test Plan: Tested locally with buck1 and buck2.

Reviewed By: seemethere, huydhn, r-barnes

Differential Revision: D38662169

fbshipit-source-id: 29704646353a44e82b1d877eeedc6adbec92352a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed fb-exported Merged