-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Manually shard slow-gradcheck CI job to prevent timeout #83354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful links
❌ 6 New FailuresAs of commit 3572be1 (more details on the Dr. CI page): Expand to see more
🕵️ 6 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Fixes #83335 [ghstack-poisoned]
Fixes #83335 [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is sad, but if it unblocks us, then this is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@pytorchbot merge -f "Preexisting failures" |
|
@pytorchbot successfully started a merge job. Check the current status here. |
|
Hey @soulitzer. |
) Summary: Fixes #83335 Pull Request resolved: #83354 Approved by: https://github.com/malfet, https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/43f950af201f8a39e5728a65e03cfcafec04585d Reviewed By: atalman Differential Revision: D38724725 Pulled By: soulitzer fbshipit-source-id: 5511e0b0c8209ef01efda67691ed59c7ef8bc06a
… (#83704) Now that pytorch/test-infra#529 exists, we can undo the custom sharding from #83354 for slow grad check test plan: look at logs to see if it sharded + look at time to see that its evenly distributed Pull Request resolved: #83704 Approved by: https://github.com/huydhn
… (#83704) Now that pytorch/test-infra#529 exists, we can undo the custom sharding from #83354 for slow grad check test plan: look at logs to see if it sharded + look at time to see that its evenly distributed Pull Request resolved: #83704 Approved by: https://github.com/huydhn
Stack from ghstack:
Fixes #83335