Update isDynamic api to align with is_symbolic API #83415

miladm · 2022-08-15T08:49:56Z

Downstream #pytorch/xla#3888

Send Pull Request

facebook-github-bot · 2022-08-15T08:50:05Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/83415
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit 24f11a3 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

miladm · 2022-08-15T19:48:16Z

@Krovatkin can I get a stamp here? I can remove the pin once you approved the change. Thanks. I will do the same for the downstream PR in PT/XLA.

Krovatkin

Krovatkin · 2022-08-16T22:11:13Z

@miladm we will need to keep the pin to make sure we don't break pytorch/master. Looks like you need to rebase PR to keep your pin cc: @JackCaoG

JackCaoG · 2022-08-16T22:14:27Z

I think we can leave the pin in this pr as it is, merge this pr. Remove the pin from the pt/xla pr and merge that pr. After midnight the bot should update pytorch's xla pin to the new master commit then we are good.

miladm · 2022-08-17T02:40:22Z

@pytorchbot rebase

miladm · 2022-08-17T02:41:48Z

Thanks for the comments. Will merge after rebase is done.

pytorchmergebot · 2022-08-17T02:42:08Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-08-17T02:42:11Z

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/master pull/83415/head returned non-zero exit code 1

Rebasing (1/2)
Rebasing (2/2)
Auto-merging .github/ci_commit_pins/xla.txt
CONFLICT (content): Merge conflict in .github/ci_commit_pins/xla.txt
error: could not apply d1e4f2c3fd... temp change to downstream torch_xla branch
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply d1e4f2c3fd... temp change to downstream torch_xla branch

Raised by https://github.com/pytorch/pytorch/actions/runs/2872404324

miladm · 2022-08-18T05:59:38Z

@pytorchbot merge

pytorchmergebot · 2022-08-18T06:00:51Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-08-18T06:00:54Z

Merge failed
Reason: Refusing to merge as mandatory check(s) Lint failed for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2880271056

miladm · 2022-08-18T16:33:47Z

@pytorchbot merge

pytorchmergebot · 2022-08-18T16:38:58Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-08-18T16:39:04Z

Merge failed
Reason: Command git -C /home/runner/work/pytorch/pytorch merge --squash __pull-request-83415__init__ returned non-zero exit code 1

Auto-merging .github/ci_commit_pins/xla.txt
CONFLICT (content): Merge conflict in .github/ci_commit_pins/xla.txt
Squash commit -- not updating HEAD
Automatic merge failed; fix conflicts and then commit the result.

Raised by https://github.com/pytorch/pytorch/actions/runs/2883916542

miladm · 2022-08-18T16:50:14Z

@pytorchbot rebase

pytorchmergebot · 2022-08-18T16:54:40Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-08-18T16:54:42Z

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/master pull/83415/head returned non-zero exit code 1

Rebasing (1/3)
Rebasing (2/3)
Auto-merging .github/ci_commit_pins/xla.txt
CONFLICT (content): Merge conflict in .github/ci_commit_pins/xla.txt
error: could not apply d1e4f2c3fd... temp change to downstream torch_xla branch
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply d1e4f2c3fd... temp change to downstream torch_xla branch

Raised by https://github.com/pytorch/pytorch/actions/runs/2883996473

miladm · 2022-08-18T22:51:56Z

@pytorchbot merge

pytorchmergebot · 2022-08-18T22:53:14Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

github-actions · 2022-08-18T22:54:10Z

Hey @miladm.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Downstream #pytorch/xla#3888 Pull Request resolved: #83415 Approved by: https://github.com/Krovatkin Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/72963bbae9b7f2a4f2e7c5fc84abdaa2f3552e73 Reviewed By: atalman Differential Revision: D38852542 fbshipit-source-id: 14ddaf06b2cafa716403355e19521cd689e6cd0d

ezyang · 2022-08-22T04:02:07Z

It doesn't seem like pytorchbot has successfully updated the pin since this landed

janeyx99 · 2022-08-22T09:12:26Z

@clee2000 looks like the hash update can't handle branch names yet/the git show does not parse the date correctly https://github.com/pytorch/pytorch/runs/7946853704?check_suite_focus=true

clee2000 · 2022-08-23T16:44:35Z

should be fixed with #83865 and hash update from last night also when through #83899

miladm added 10 commits May 18, 2022 19:40

Merge pull request #1 from pytorch/master

3a2009d

Send Pull Request

Merge branch 'pytorch:master' into master

849ec70

Merge branch 'pytorch:master' into master

5d2325a

Merge branch 'pytorch:master' into master

49da1b3

Merge branch 'pytorch:master' into master

b986f69

Merge branch 'pytorch:master' into master

86fb62d

Merge branch 'pytorch:master' into master

fdf7072

Merge branch 'pytorch:master' into master

5752606

Merge branch 'pytorch:master' into master

0531e8e

Merge branch 'pytorch:master' into master

c8edc79

miladm requested a review from a team as a code owner August 15, 2022 08:49

facebook-github-bot added the cla signed label Aug 15, 2022

miladm self-assigned this Aug 15, 2022

pytorchbot added the open source label Aug 15, 2022

miladm mentioned this pull request Aug 15, 2022

Update isDynamic api to align with is_symbolic API in upstream pytorch/xla#3888

Merged

samdow added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 15, 2022

miladm requested a review from Krovatkin August 15, 2022 17:43

miladm added the lazy Lazy Tensor work items label Aug 15, 2022

Krovatkin approved these changes Aug 16, 2022

View reviewed changes

miladm added 4 commits August 18, 2022 17:07

Merge branch 'master' of github.com:miladm/pytorch

66297fc

Merge branch 'master' of github.com:miladm/pytorch

791a5bc

updating isdynamic api

4ccb8be

temp change to downstream torch_xla branch

24f11a3

miladm force-pushed the update_is_dynamic_api branch from a4a4d5d to 24f11a3 Compare August 18, 2022 17:09

pytorchmergebot added the Merged label Aug 18, 2022

pytorchmergebot closed this in 72963bb Aug 18, 2022

Update isDynamic api to align with is_symbolic API #83415

Update isDynamic api to align with is_symbolic API #83415

Uh oh!

Conversation

miladm commented Aug 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Aug 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

✅ No Failures (0 Pending)

Uh oh!

miladm commented Aug 15, 2022

Uh oh!

Krovatkin left a comment

Choose a reason for hiding this comment

Uh oh!

Krovatkin commented Aug 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackCaoG commented Aug 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miladm commented Aug 17, 2022

Uh oh!

miladm commented Aug 17, 2022

Uh oh!

pytorchmergebot commented Aug 17, 2022

Uh oh!

pytorchmergebot commented Aug 17, 2022

Uh oh!

miladm commented Aug 18, 2022

Uh oh!

pytorchmergebot commented Aug 18, 2022

Uh oh!

pytorchmergebot commented Aug 18, 2022

Uh oh!

miladm commented Aug 18, 2022

Uh oh!

pytorchmergebot commented Aug 18, 2022

Uh oh!

pytorchmergebot commented Aug 18, 2022

Uh oh!

miladm commented Aug 18, 2022

Uh oh!

pytorchmergebot commented Aug 18, 2022

Uh oh!

pytorchmergebot commented Aug 18, 2022

Uh oh!

miladm commented Aug 18, 2022

Uh oh!

pytorchmergebot commented Aug 18, 2022

Uh oh!

github-actions bot commented Aug 18, 2022

Uh oh!

ezyang commented Aug 22, 2022

Uh oh!

janeyx99 commented Aug 22, 2022

Uh oh!

clee2000 commented Aug 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

miladm commented Aug 15, 2022 •

edited

Loading

facebook-github-bot commented Aug 15, 2022 •

edited

Loading

Krovatkin commented Aug 16, 2022 •

edited

Loading

JackCaoG commented Aug 16, 2022 •

edited

Loading