Skip to content

Conversation

@schlagercollin
Copy link
Contributor

Fix TODOs related to #38095 in test_unary_ufuncs.py

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 19, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 3b32e70 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.


# Tests complex out
np_complex_out = np_fn(a)
np_complex_out = np_fn(a).astype(torch_to_numpy_dtype_dict[dtype])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the subsequent two "complex out" tests, I'm assuming that the expected behavior of torch_fn(t, out=complex_out) is to populate the complex_out tensor with the output, keeping the dtype of complex_out.

Accordingly, for proper type checking, we must cast np_complex_out to the dtype of complex_out (which happens to be the variable dtype in this scope).

@schlagercollin schlagercollin requested a review from kit1980 August 19, 2022 00:29
@schlagercollin
Copy link
Contributor Author

@pytorchbot label todo-elimination

@kit1980 kit1980 added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Aug 19, 2022
@schlagercollin schlagercollin changed the title [WIP] Remove assertEqualIgnoreTypes from test_unary_ufuncs Remove assertEqualIgnoreTypes from test_unary_ufuncs Aug 19, 2022
@schlagercollin schlagercollin marked this pull request as ready for review August 19, 2022 05:01
@schlagercollin
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

Hey @schlagercollin.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants