-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Remove assertEqualIgnoreTypes from test_unary_ufuncs #83711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 3b32e70 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
|
||
| # Tests complex out | ||
| np_complex_out = np_fn(a) | ||
| np_complex_out = np_fn(a).astype(torch_to_numpy_dtype_dict[dtype]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the subsequent two "complex out" tests, I'm assuming that the expected behavior of torch_fn(t, out=complex_out) is to populate the complex_out tensor with the output, keeping the dtype of complex_out.
Accordingly, for proper type checking, we must cast np_complex_out to the dtype of complex_out (which happens to be the variable dtype in this scope).
|
@pytorchbot label todo-elimination |
|
@pytorchbot merge |
|
@pytorchbot successfully started a merge job. Check the current status here. |
|
Hey @schlagercollin. |
Fix TODOs related to #38095 in test_unary_ufuncs.py