-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Enable cache action for lint workflow #84026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84026
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 645b2ec: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the expected impact on this change on TTS?
Not much I think because installing dependencies isn't the long pole in term of TTS. However, it has a minor reliability boon that allows the cached copies to be used whenever there are upstream issues with pip. And the setup is pretty easy as you can see in the PR. Basically, we just need to add to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coolio
|
Looks good, but please avoid images in PR description, rather share link to respective runs + text-readable perf numbers |
|
@pytorchbot merge |
|
@pytorchbot successfully started a merge job. Check the current status here and land check progress here. |
Cache all python dependencies using [GHA cache](https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows). I'm doing this for lint workflow first and will slowly roll it out to other workflows. ### Testing Before caching, pip cache is not found. Dependencies installation continues as usual:  After caching https://github.com/pytorch/pytorch/runs/8006214772?check_suite_focus=true. The long hash at the end of the cache key is the hash of requirements files  Note that the cache is in the runners themselves. This should be a transparent process. Pull Request resolved: #84026 Approved by: https://github.com/seemethere, https://github.com/suo, https://github.com/malfet
|
Hey @huydhn. |
|
One needs to be careful with introducing new dependencies, as lint will fail for all users that have not rebased, as workflow definition is checked from master, but rest of the code is from PR, which results in the following failures: |
Note. In hindsight, I should have added the new file first, then made the change. |
Following up on #84026, these are the rest of pip dependencies that I can find. Pull Request resolved: #84093 Approved by: https://github.com/malfet
Summary: Cache all python dependencies using [GHA cache](https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows). I'm doing this for lint workflow first and will slowly roll it out to other workflows. ### Testing Before caching, pip cache is not found. Dependencies installation continues as usual:  After caching https://github.com/pytorch/pytorch/runs/8006214772?check_suite_focus=true. The long hash at the end of the cache key is the hash of requirements files  Note that the cache is in the runners themselves. This should be a transparent process. Pull Request resolved: #84026 Approved by: https://github.com/seemethere, https://github.com/suo, https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/02c3781332031981988cd0cadfd573a210210b33 Reviewed By: weiwangmeta Differential Revision: D39025475 Pulled By: huydhn fbshipit-source-id: e4506911cb662bcf4c32db4225acdb0acd9da760
Following up on #84026, these are the rest of pip dependencies that I can find. Pull Request resolved: #84093 Approved by: https://github.com/malfet
…84093) Summary: Following up on #84026, these are the rest of pip dependencies that I can find. Pull Request resolved: #84093 Approved by: https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/82efb0e196c71a75985595fbbf294d8c816e9753 Reviewed By: weiwangmeta Differential Revision: D39084828 Pulled By: huydhn fbshipit-source-id: 2fddfcddd7291f1ee57bc697fd9b18ab2c67a1f0
…84093) Summary: Following up on #84026, these are the rest of pip dependencies that I can find. Pull Request resolved: #84093 Approved by: https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/82efb0e196c71a75985595fbbf294d8c816e9753 Reviewed By: weiwangmeta Differential Revision: D39089768 Pulled By: huydhn fbshipit-source-id: f5ae04ce6ca885a0255ead44dd583b160ebe35d5
Cache all python dependencies using GHA cache. I'm doing this for lint workflow first and will slowly roll it out to other workflows.
Testing
Before caching, pip cache is not found. Dependencies installation continues as usual:
After caching https://github.com/pytorch/pytorch/runs/8006214772?check_suite_focus=true. The long hash at the end of the cache key is the hash of requirements files
Note that the cache is in the runners themselves. This should be a transparent process.