Skip to content

Conversation

@dagitses
Copy link
Collaborator

@dagitses dagitses commented Aug 31, 2022

Stack from ghstack (oldest at bottom):

Summary:
This will make it easier to compare and spot missing files.

Test Plan: Rely on CI.

Reviewers:

Subscribers:

Tasks:

Tags:

Summary:
This will make it easier to compare and spot missing files.

Test Plan: Rely on CI.

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 31, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84344

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 Failures

As of commit 21088c8:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you please move this list to build_variables.bzl?

Also, why not use glob (perhaps as followup PR)

@dagitses
Copy link
Collaborator Author

LGTM, but can you please move this list to build_variables.bzl?

Also, why not use glob (perhaps as followup PR)

Sure. FWIW, we are using a glob internally.

@dagitses
Copy link
Collaborator Author

@pytorchbot merge --force='all breakages are from trunk, this is unlikely to add any breakages'

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Sep 2, 2022
Summary:
This will make it easier to compare and spot missing files.

Pull Request resolved: #84344
Approved by: https://github.com/malfet

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/040263d7dc7bd1e4e620bd1889717890b1bf9b30

Test plan from GitHub:
Rely on CI.

Reviewed By: mehtanirav

Differential Revision: D39213498

Pulled By: dagitses

fbshipit-source-id: e13deb6d82ea819e9ed334ce9a1d08522380739c
@facebook-github-bot facebook-github-bot deleted the gh/dagitses/393/head branch September 4, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants