-
Notifications
You must be signed in to change notification settings - Fork 25.7k
sort ATen tests in CMake #84344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sort ATen tests in CMake #84344
Conversation
Summary: This will make it easier to compare and spot missing files. Test Plan: Rely on CI. Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84344
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 FailuresAs of commit 21088c8: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but can you please move this list to build_variables.bzl?
Also, why not use glob (perhaps as followup PR)
Sure. FWIW, we are using a glob internally. |
|
@pytorchbot merge --force='all breakages are from trunk, this is unlikely to add any breakages' |
|
@pytorchbot successfully started a merge job. Check the current status here. |
|
Hey @dagitses. |
Summary: This will make it easier to compare and spot missing files. Pull Request resolved: #84344 Approved by: https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/040263d7dc7bd1e4e620bd1889717890b1bf9b30 Test plan from GitHub: Rely on CI. Reviewed By: mehtanirav Differential Revision: D39213498 Pulled By: dagitses fbshipit-source-id: e13deb6d82ea819e9ed334ce9a1d08522380739c
Stack from ghstack (oldest at bottom):
Summary:
This will make it easier to compare and spot missing files.
Test Plan: Rely on CI.
Reviewers:
Subscribers:
Tasks:
Tags: