-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Fixing back invariant on offsets #84433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful links
❌ 1 New FailuresAs of commit 96f0fa1 (more details on the Dr. CI page): Expand to see more
🕵️♀️ 1 failure not recognized by patterns:This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@pytorchbot merge -l |
|
@pytorchbot successfully started a merge job. Check the current status here and land check progress here. |
# Summary I changed the calculation of offsets to add an extra element for bounding above. This invariant makes sense in the contiguous case but when ntesnor[i] is sliced like in this pr: #83736 this doesn't make semantic sense anymore. SO changing back, Borderline stampy Pull Request resolved: #84433 Approved by: https://github.com/mikaylagawarecki
|
Hey @drisspg. |
Summary: # Summary I changed the calculation of offsets to add an extra element for bounding above. This invariant makes sense in the contiguous case but when ntesnor[i] is sliced like in this pr: #83736 this doesn't make semantic sense anymore. SO changing back, Borderline stampy Pull Request resolved: #84433 Approved by: https://github.com/mikaylagawarecki Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/73cb6cf8ae355417e0e9b6b9614492b280f66ae7 Reviewed By: mehtanirav Differential Revision: D39277388 Pulled By: drisspg fbshipit-source-id: d0ba731b4698bee8595196f5ef9c414f10ce99b4
Summary
I changed the calculation of offsets to add an extra element for bounding above. This invariant makes sense in the contiguous case but when ntesnor[i] is sliced like in this pr: #83736 this doesn't make semantic sense anymore. SO changing back, Borderline stampy