OpInfo: use functools.partial to decrease noise in make_tensor calls #84455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
This was referenced Sep 2, 2022
🔗 Helpful links
✅ No Failures (33 Pending)As of commit 79e1de0 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
|
Ahhh, nice! |
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84455
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 Failures, 1 PendingAs of commit 5bb5eba: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
peterbell10
added a commit
to peterbell10/pytorch
that referenced
this pull request
Oct 3, 2022
This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. ghstack-source-id: a735247 Pull Request resolved: pytorch#84455
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
|
|
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
…nsor calls" This `make_arg` convention removes a lot of visual clutter in the sample input functions, so lets use it everywhere. [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This
make_argconvention removes a lot of visual clutter in thesample input functions, so lets use it everywhere.