Skip to content

Conversation

@peterbell10
Copy link
Collaborator

@peterbell10 peterbell10 commented Sep 2, 2022

Stack from ghstack (oldest at bottom):

These files are already only using the subset avalilable with
TensorBase, so this is straight-forward name substitution.

These files are already only using the subset avalilable with
TensorBase, so this is straight-forward name substitution.

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 2, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 67ec991 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@peterbell10 peterbell10 marked this pull request as ready for review September 2, 2022 23:06
@peterbell10 peterbell10 requested a review from ezyang September 2, 2022 23:07
These files are already only using the subset avalilable with
TensorBase, so this is straight-forward name substitution.

[ghstack-poisoned]
peterbell10 added a commit that referenced this pull request Sep 5, 2022
These files are already only using the subset avalilable with
TensorBase, so this is straight-forward name substitution.

ghstack-source-id: 5dbcfe8
Pull Request resolved: #84499
@ezyang
Copy link
Contributor

ezyang commented Sep 6, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Hey @peterbell10.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@peterbell10 peterbell10 added the topic: not user facing topic category label Sep 6, 2022
facebook-github-bot pushed a commit that referenced this pull request Sep 7, 2022
Summary:
These files are already only using the subset avalilable with
TensorBase, so this is straight-forward name substitution.

Pull Request resolved: #84499
Approved by: https://github.com/ezyang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/26c136a135fe0215195a6e0566651baaffb01159

Reviewed By: mehtanirav

Differential Revision: D39277832

fbshipit-source-id: f72686162949163f0d4d8d373f082784ef38bf53
@facebook-github-bot facebook-github-bot deleted the gh/peterbell10/413/head branch September 9, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants