Skip to content

Reenable TestCppExtensionJIT on M1 #84552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Reenable TestCppExtensionJIT on M1 #84552

wants to merge 1 commit into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Sep 5, 2022 •
edited
Loading

Works fine locally, let's see if it'll pass CI

@malfet
Reenable TestCppExtensionJIT on M1
b66811d 
Works fine locally, let's see if it'll pass CI
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 5, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84552

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 1 Pending

As of commit b66811d:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 5, 2022
@malfet malfet requested a review from a team September 6, 2022 17:19
@malfet
Copy link
Contributor Author

malfet commented Sep 6, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Sep 8, 2022
@malfet @facebook-github-bot
Reenable TestCppExtensionJIT on M1 (#84552) (#84552)
9a1ff51 
Summary:
Works fine locally, let's see if it'll pass CI

Pull Request resolved: #84552
Approved by: https://github.com/kit1980

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/c794ee5cc12192da527bbbcf5c5b9ec33c935cbe

Reviewed By: izaitsevfb

Differential Revision: D39296914

Pulled By: malfet

fbshipit-source-id: a1c55652a128bb687d7bfdeb50a047f915ea8c55
@malfet malfet deleted the malfet/reenable-cppextension-jit-on-arm64 branch September 9, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malfet @pytorchmergebot @kit1980 @facebook-github-bot