Skip to content

[ONNX] Add third_party/onnx to merge rule #84715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Add extra debug info for the super common "index out of bounds" error.
wants to merge 1 commit into from
Closed

[ONNX] Add third_party/onnx to merge rule #84715

wants to merge 1 commit into from

Conversation

@BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Sep 8, 2022

We expect to bump onnx submodule version regularly to develop support for new onnx operators/functions. Adding this to merge rule reduces the burden for core maintainers for approval.

@BowenBao BowenBao added the module: onnx Related to torch.onnx label Sep 8, 2022
@BowenBao BowenBao requested a review from malfet September 8, 2022 18:18
@BowenBao BowenBao requested a review from a team as a code owner September 8, 2022 18:18
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 8, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84715

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f65e263:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Sep 8, 2022
@BowenBao BowenBao mentioned this pull request Sep 8, 2022
Closed
@thiagocrepaldi
Copy link
Collaborator

thiagocrepaldi commented Sep 8, 2022 •
edited
Loading

#83201 could be approved/merged by us with this PR

@BowenBao BowenBao added the onnx-needs-import This PR is related to ONNX, but touches files outside of merge rule patterns, and hence needs import label Sep 12, 2022
@BowenBao
Copy link
Collaborator Author

@pytorchbot rebase

@BowenBao
Copy link
Collaborator Author

@malfet please take a look and let me know if it makes sense.

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@BowenBao @pytorchmergebot
[ONNX] Add third_party/onnx to merge rule
f65e263 
We expect to bump onnx submodule version regularly to develop support for new onnx operators/functions. Adding this to merge rule reduces the burden for core maintainers for approval.
@pytorchmergebot
Copy link
Collaborator

Successfully rebased bowbao/onnx_merge_rule onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout bowbao/onnx_merge_rule && git pull --rebase)

malfet
malfet approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can give it a try, but 3rd party is a bit tricky as it can add additional submodules and cause internal regressions.

@BowenBao
Copy link
Collaborator Author

We can give it a try, but 3rd party is a bit tricky as it can add additional submodules and cause internal regressions.

Sure, we will treat with caution and check with you if there are larger changes other than releasing new operator/opset.

@BowenBao
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

Hey @BowenBao.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@BowenBao BowenBao added the topic: not user facing topic category label Sep 15, 2022
@BowenBao BowenBao mentioned this pull request Sep 15, 2022
Closed
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@BowenBao @mehtanirav
[ONNX] Add third_party/onnx to merge rule (#84715)
15d83a3 
We expect to bump onnx submodule version regularly to develop support for new onnx operators/functions. Adding this to merge rule reduces the burden for core maintainers for approval.

Pull Request resolved: #84715
Approved by: https://github.com/thiagocrepaldi, https://github.com/malfet
@github-actions github-actions bot deleted the bowbao/onnx_merge_rule branch March 14, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@thiagocrepaldi thiagocrepaldi thiagocrepaldi approved these changes

Assignees

No one assigned

Labels

cla signed Merged module: onnx Related to torch.onnx onnx-needs-import This PR is related to ONNX, but touches files outside of merge rule patterns, and hence needs import open source release notes: releng release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BowenBao @thiagocrepaldi @pytorchmergebot @malfet @facebook-github-bot @pytorchbot