Upload the benchmark result to S3 and post the URL #84726
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84726
Note: Links to docs will display an error until the docs builds have been completed. ✅ No Failures, 1 PendingAs of commit 87bf26e: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| def upload_file(self, file_path: Path, filekey_prefix: str) -> None: | ||
| assert file_path.is_file(), f"Specified file path {file_path} does not exist or not file." | ||
| file_name = file_path.name | ||
| s3_key = f"{self.prefix}/{filekey_prefix}/{file_name}" |
There was a problem hiding this comment.
Is filekey_prefix unique or would it could repeated over multiple runs of the same PR or the same git commit?
There was a problem hiding this comment.
It is the same for the same PR, the second run will overwrite the result of the first run.
There was a problem hiding this comment.
Let me know if you need to keep the run history. If you do, we probably can do it in a follow-up PR.
|
@pytorchbot -g merge |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot merge |
|
@pytorchbot successfully started a merge job. Check the current status here. |
|
Hey @xuzhao9. |
Summary: Upload the benchmark result to S3 and make it accessible to the public. The URL is available at the end of the "Upload to S3" step of the workflow. For example, this PR uploads 3 files: ``` Uploaded the result file control.json to https://ossci-metrics.s3.amazonaws.com/torchbench-pr-test/pr84726/control.json Uploading file treatment.json to S3 with key: torchbench-pr-test/pr84726/treatment.json Uploaded the result file treatment.json to https://ossci-metrics.s3.amazonaws.com/torchbench-pr-test/pr84726/treatment.json Uploading file result.csv to S3 with key: torchbench-pr-test/pr84726/result.csv Uploaded the result file result.csv to https://ossci-metrics.s3.amazonaws.com/torchbench-pr-test/pr84726/result.csv ``` RUN_TORCHBENCH: nvfuser Pull Request resolved: #84726 Approved by: https://github.com/davidberard98 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/cd50512d414e352fb9088805d8d66bf6880895d1 Reviewed By: izaitsevfb Differential Revision: D39407102 Pulled By: xuzhao9 fbshipit-source-id: 163a916b4cdb1ae768be6f55a1bf3d41c4660462
4 participants
Upload the benchmark result to S3 and make it accessible to the public.
The URL is available at the end of the "Upload to S3" step of the workflow. For example, this PR uploads 3 files:
RUN_TORCHBENCH: nvfuser