Skip to content

Conversation

@titaiwangms
Copy link
Collaborator

@titaiwangms titaiwangms commented Sep 9, 2022

Stack from ghstack (oldest at bottom):

Address the AT_ASSERT in torch/jit/csrc/passes/onnx.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 9, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84790

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d30eba3:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Sep 9, 2022
@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Sep 9, 2022
titaiwangms added a commit that referenced this pull request Sep 9, 2022
ghstack-source-id: 0231aae
Pull Request resolved: #84790
@titaiwangms titaiwangms added the module: onnx Related to torch.onnx label Sep 9, 2022
@titaiwangms titaiwangms linked an issue Sep 9, 2022 that may be closed by this pull request
@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

Hey @AllenTiTaiWang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@titaiwangms titaiwangms added the topic: not user facing topic category label Sep 13, 2022
@ZainRizvi ZainRizvi added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Sep 13, 2022
@facebook-github-bot facebook-github-bot deleted the gh/AllenTiTaiWang/9/head branch September 16, 2022 14:20
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR cla signed Merged module: onnx Related to torch.onnx oncall: jit Add this issue/PR to JIT oncall triage queue open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ONNX] replace AT_ASSERT with TORCH_INTERNAL_ASSERT

6 participants