Skip to content

Conversation

@ZainRizvi
Copy link
Contributor

TestDataLoaderUtils needs to run it's parent class's setUp method to actually disable flaky tests (see #70516 (comment) for details)

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 14, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85018

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 7e47971:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 14, 2022
@ZainRizvi ZainRizvi requested review from a team and janeyx99 September 14, 2022 17:37
@ZainRizvi ZainRizvi marked this pull request as ready for review September 14, 2022 17:37
@ZainRizvi ZainRizvi added accept2ship ciflow/trunk Trigger trunk jobs on your pull request labels Sep 14, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 14, 2022

This PR has been accepted with the accept2ship label. Attempting to merge now.

@pytorchbot merge -l

@pytorch-bot pytorch-bot bot removed the accept2ship label Sep 14, 2022
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the land checks (-l) flag. If you did not specify this flag yourself, you are likely enrolled in the land checks rollout. This means that your change will be merged once all checks on your PR have passed since you have added the ciflow/trunk label to your PR (ETA 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@malfet malfet changed the title Disable TestDataLoaderUtils tests when they're marked as flaky Fix inheritance in TestDataLoaderUtil Sep 14, 2022
@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@malfet
Copy link
Contributor

malfet commented Sep 14, 2022

@pytorchbot merge -g

Cancelled previous workflow, as PR title would otherwise be very confusing

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@ZainRizvi ZainRizvi changed the title Fix inheritance in TestDataLoaderUtil TestDataLoaderUtil's setUp should invoke super class Sep 14, 2022
@ZainRizvi ZainRizvi changed the title TestDataLoaderUtil's setUp should invoke super class Fix inheritance in TestDataLoaderUtil Sep 14, 2022
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 additional jobs have failed, first few of them are: trunk ,trunk / macos-12-py3-arm64-mps / Run MPS tests ,trunk / macos-12-py3-arm64 / test (default, 2, 2, macos-m1-12)

Details for Dev Infra team Raised by workflow job

@ZainRizvi
Copy link
Contributor Author

@pytorchmergebot merge -f "Errors are unrelated"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@ZainRizvi ZainRizvi deleted the zainr/disable-flaky branch September 30, 2022 22:25
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
TestDataLoaderUtils needs to run it's parent class's setUp method to actually disable flaky tests (see #70516 (comment) for details)
Pull Request resolved: #85018
Approved by: https://github.com/clee2000, https://github.com/huydhn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants