Remove getattr magic method from OpOverload #85090
Conversation
Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85090
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ceac404: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| def __call__(self, *args, **kwargs): | ||
| return self._op(*args, **kwargs or {}) | ||
|
|
||
| def __getattr__(self, key): |
There was a problem hiding this comment.
why does this work? is key also in the attrs of self, or are we now causing an AttributeError and that's desirable for some reason?
There was a problem hiding this comment.
I removed this mostly because I didn't know why we have it, and because in a subsequent PR I am going to redefine getattr for other reasons
|
@pytorchbot merge |
|
@pytorchbot successfully started a merge job. Check the current status here. |
|
Hey @ezyang. |
Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: #85090 Approved by: https://github.com/wconstab
4 participants
Stack from ghstack (oldest at bottom):
Signed-off-by: Edward Z. Yang ezyang@fb.com