Make ones and zeros's ref accepts variadic size argument #85117

SherlockNoMad · 2022-09-15T22:01:37Z

Stack from ghstack (oldest at bottom):

-> Make ones and zeros's ref accepts variadic size argument #85117

[ghstack-poisoned]

pytorch-bot · 2022-09-15T22:01:39Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85117

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4fda299:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ngimel · 2022-09-16T00:13:50Z

torch/_refs/__init__.py

 @out_wrapper()
 def zeros(
-    size: ShapeType,
-    *,


why did you remove kwarg-only? dtype and following args are kwarg only.

Python syntax actually doesn't allow this: Keyword-only argument separator not allowed after "*parameter"

Coz, arguments after "*parameter" are implicitly kwarg-only...

@overload def ones(size: _size, *, out: Optional[Tensor]=None, dtype: Optional[_dtype]=None, layout: Optional[_layout]=None, device: Optional[Union[_device, str, None]]=None, pin_memory: Optional[_bool]=False, requires_grad: Optional[_bool]=False) -> Tensor: ... @overload def ones(*size: _int, out: Optional[Tensor]=None, dtype: Optional[_dtype]=None, layout: Optional[_layout]=None, device: Optional[Union[_device, str, None]]=None, pin_memory: Optional[_bool]=False, requires_grad: Optional[_bool]=False) -> Tensor: ...

These are the overloads for torch.ones.
So what we have in the doc, def one(*size, *, ...) , is actually invalid

ok cool, can you add some sample or reference input to exercise new code path? Apparently tests were not failing previously even though they should have.

I added the test cases in opinf db for ones and zeros....
However, the test infra is alway normalizing the inputs to a tuple, so technically it's still not testing the non-tuple size case...
I guess if we really want to test the non-tuple case, we need to carve out an code path just for this purpose. Do we really want to do this?

Yeah ok, we can leave it as is.

[ghstack-poisoned]

ghstack-source-id: d8a1799 Pull Request resolved: #85117

lezcano

Cool, thank you!

[ghstack-poisoned]

SherlockNoMad · 2022-09-16T16:52:19Z

@pytorchbot merge -g

pytorchmergebot · 2022-09-16T16:53:59Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

[ghstack-poisoned]

pytorchmergebot · 2022-09-16T17:09:04Z

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team

Raised by workflow job

SherlockNoMad · 2022-09-16T19:52:37Z

@pytorchbot merge -g

pytorchmergebot · 2022-09-16T19:54:00Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

github-actions · 2022-09-16T19:54:54Z

Hey @SherlockNoMad.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

ZainRizvi · 2022-09-16T21:04:51Z

@pytorchmergebot revert -c nosignal -m "Failed trunk"

pytorchmergebot · 2022-09-16T21:06:21Z

@pytorchbot successfully started a revert job. Check the current status here.
Please reach out to the PyTorch DevX Team with feedback or questions!

[ghstack-poisoned]

SherlockNoMad · 2022-09-20T06:23:21Z

@pytorchbot merge -g

pytorchmergebot · 2022-09-20T06:25:07Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-09-20T06:25:10Z

Merge failed

Reason: 1 additional jobs have failed, first few of them are: trunk

Details for Dev Infra team

Raised by workflow job

SherlockNoMad · 2022-09-20T06:29:00Z

@pytorchbot rebase -s

pytorchmergebot · 2022-09-20T06:30:48Z

@pytorchbot successfully started a rebase job. Check the current status here

[ghstack-poisoned]

pytorchmergebot · 2022-09-20T06:31:04Z

Successfully rebased gh/SherlockNoMad/26/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/85117)

ghstack-source-id: 5942d13 Pull Request resolved: #85117

SherlockNoMad · 2022-09-20T16:39:58Z

@pytorchbot merge -g

pytorchmergebot · 2022-09-20T16:41:28Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

github-actions · 2022-09-20T16:42:21Z

Hey @SherlockNoMad.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Pull Request resolved: #85117 Approved by: https://github.com/ngimel, https://github.com/Lezcano

)" This reverts commit 7e5616c. Reverted #85117 on behalf of https://github.com/ZainRizvi due to Failed trunk

Pull Request resolved: #85117 Approved by: https://github.com/ngimel, https://github.com/lezcano

Make ones and zeros's ref accepts variadic size argument

166fa5d

[ghstack-poisoned]

facebook-github-bot added the cla signed label Sep 15, 2022

SherlockNoMad requested review from lezcano and ngimel September 15, 2022 22:01

SherlockNoMad mentioned this pull request Sep 15, 2022

Rewrite new_zeros, new_ones, new_full decomp with aten.full #84946

Closed

ngimel reviewed Sep 16, 2022

View reviewed changes

Update on "Make ones and zeros's ref accepts variadic size argument"

8e171fd

[ghstack-poisoned]

SherlockNoMad requested a review from mruberry as a code owner September 16, 2022 03:39

SherlockNoMad added a commit that referenced this pull request Sep 16, 2022

Make ones and zeros's ref accepts variadic size argument

449071f

ghstack-source-id: d8a1799 Pull Request resolved: #85117

ngimel approved these changes Sep 16, 2022

View reviewed changes

lezcano approved these changes Sep 16, 2022

View reviewed changes

Update on "Make ones and zeros's ref accepts variadic size argument"

5cf52e0

[ghstack-poisoned]

Update on "Make ones and zeros's ref accepts variadic size argument"

0c622ba

[ghstack-poisoned]

pytorchmergebot added the Merged label Sep 16, 2022

pytorchmergebot closed this in 7e5616c Sep 16, 2022

ZainRizvi added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 16, 2022

ZainRizvi removed the ciflow/trunk Trigger trunk jobs on your pull request label Sep 16, 2022

SherlockNoMad reopened this Sep 16, 2022

SherlockNoMad added ciflow/trunk Trigger trunk jobs on your pull request and removed Merged labels Sep 16, 2022

Update on "Make ones and zeros's ref accepts variadic size argument"

37598cc

[ghstack-poisoned]

SherlockNoMad removed the ciflow/trunk Trigger trunk jobs on your pull request label Sep 20, 2022

Update on "Make ones and zeros's ref accepts variadic size argument"

4fda299

[ghstack-poisoned]

pytorchmergebot pushed a commit that referenced this pull request Sep 20, 2022

Make ones and zeros's ref accepts variadic size argument

11505b7

ghstack-source-id: 5942d13 Pull Request resolved: #85117

pytorchmergebot added the Merged label Sep 20, 2022

pytorchmergebot closed this in 9c1a6a5 Sep 20, 2022

ngimel mentioned this pull request Sep 22, 2022

Make Python reference for permute accept varargs #85460

Closed

facebook-github-bot deleted the gh/SherlockNoMad/26/head branch September 24, 2022 14:20

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022

Make ones and zeros's ref accepts variadic size argument (#85117)

ad53d2d

Pull Request resolved: #85117 Approved by: https://github.com/ngimel, https://github.com/Lezcano

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022

Revert "Make ones and zeros's ref accepts variadic size argument (#85117

c6c2fa2

)" This reverts commit 7e5616c. Reverted #85117 on behalf of https://github.com/ZainRizvi due to Failed trunk

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022

Make ones and zeros's ref accepts variadic size argument (#85117)

1c13741

Pull Request resolved: #85117 Approved by: https://github.com/ngimel, https://github.com/lezcano

Make ones and zeros's ref accepts variadic size argument #85117

Make ones and zeros's ref accepts variadic size argument #85117

Uh oh!

Conversation

SherlockNoMad commented Sep 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85117

✅ No Failures

Uh oh!

ngimel Sep 16, 2022

Choose a reason for hiding this comment

Uh oh!

SherlockNoMad Sep 16, 2022

Choose a reason for hiding this comment

Uh oh!

SherlockNoMad Sep 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ngimel Sep 16, 2022

Choose a reason for hiding this comment

Uh oh!

SherlockNoMad Sep 16, 2022

Choose a reason for hiding this comment

Uh oh!

ngimel Sep 16, 2022

Choose a reason for hiding this comment

Uh oh!

lezcano left a comment

Choose a reason for hiding this comment

Uh oh!

SherlockNoMad commented Sep 16, 2022

Uh oh!

pytorchmergebot commented Sep 16, 2022

Uh oh!

pytorchmergebot commented Sep 16, 2022

Merge failed

Uh oh!

SherlockNoMad commented Sep 16, 2022

Uh oh!

pytorchmergebot commented Sep 16, 2022

Uh oh!

github-actions bot commented Sep 16, 2022

Uh oh!

ZainRizvi commented Sep 16, 2022

Uh oh!

pytorchmergebot commented Sep 16, 2022

Uh oh!

SherlockNoMad commented Sep 20, 2022

Uh oh!

pytorchmergebot commented Sep 20, 2022

Uh oh!

pytorchmergebot commented Sep 20, 2022

Merge failed

Uh oh!

SherlockNoMad commented Sep 20, 2022

Uh oh!

pytorchmergebot commented Sep 20, 2022

Uh oh!

pytorchmergebot commented Sep 20, 2022

Uh oh!

SherlockNoMad commented Sep 20, 2022

Uh oh!

pytorchmergebot commented Sep 20, 2022

Uh oh!

github-actions bot commented Sep 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SherlockNoMad commented Sep 15, 2022 •

edited

Loading

pytorch-bot bot commented Sep 15, 2022 •

edited

Loading

SherlockNoMad Sep 16, 2022 •

edited

Loading