Skip to content

Re-introduce torch.Tensor.to_padded_tensor #85293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Re-introduce torch.Tensor.to_padded_tensor #85293

wants to merge 4 commits into from

Conversation

mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Sep 19, 2022 •
edited by pytorchmergebot
Loading

Stack from ghstack (oldest at bottom):

Differential Revision: D39629004

@mikaylagawarecki
Re-introduce
c0ec052 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 19, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85293

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 8cca6ae:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mikaylagawarecki mikaylagawarecki changed the title Re-introduce Re-introduce torch.Tensor.to_padded_tensor Sep 19, 2022
@mikaylagawarecki
Copy link
Contributor Author

@mikaylagawarecki has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mikaylagawarecki
Copy link
Contributor Author

@mikaylagawarecki has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

mikaylagawarecki added a commit that referenced this pull request Sep 19, 2022
@mikaylagawarecki
Re-introduce to_padded_tensor
efc29b8 
ghstack-source-id: 127afa3
Pull Request resolved: #85293
@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot rebase -s

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorch-bot pytorch-bot bot added the release notes: nn release notes category label Sep 20, 2022
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/mikaylagawarecki/82/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/85293)

pytorchmergebot pushed a commit that referenced this pull request Sep 20, 2022
@mikaylagawarecki
Re-introduce to_padded_tensor
22b480c 
ghstack-source-id: d7c014f
Pull Request resolved: #85293
drisspg
drisspg reviewed Sep 20, 2022
View reviewed changes
aten/src/ATen/native/native_functions.yaml
dispatch:
CompositeExplicitAutograd: alias_copy_out

- func: to_padded_tensor(Tensor self, float padding, int[]? output_size=None) -> Tensor
Copy link
Contributor

@drisspg drisspg Sep 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albanD removing the method seemed to cause a decent amount of headaches for internal users. I don't like that we can't break BC though however. Would adding this as a method on class Tensor in python make a significant difference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might not be torch scriptable if we add it on a class Tensor at the python level @cpuhrsch is this what you were getting at yesterday?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally I noticed that to_dense which seems like the analogous function to to_padded_tensor for sparse is a method registered as a native function

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's painful, you can keep it here for sure yes.

@mikaylagawarecki
Copy link
Contributor Author

@mikaylagawarecki has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mikaylagawarecki
Copy link
Contributor Author

@mikaylagawarecki has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

Hey @mikaylagawarecki.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@mikaylagawarecki mikaylagawarecki added topic: not user facing topic category topic: bug fixes topic category release notes: nested tensor Changes that have a direct impact on nested tensors and removed release notes: nn release notes category topic: not user facing topic category labels Sep 21, 2022
@facebook-github-bot facebook-github-bot deleted the gh/mikaylagawarecki/82/head branch September 25, 2022 14:19
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@mikaylagawarecki @mehtanirav
Re-introduce torch.Tensor.to_padded_tensor (#85293)
af243e9 
Differential Revision: [D39629004](https://our.internmc.facebook.com/intern/diff/D39629004)
Pull Request resolved: #85293
Approved by: https://github.com/cpuhrsch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD left review comments

@drisspg drisspg drisspg left review comments

@cpuhrsch cpuhrsch cpuhrsch approved these changes

Assignees

No one assigned

Labels

cla signed Merged release notes: nested tensor Changes that have a direct impact on nested tensors topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mikaylagawarecki @pytorchmergebot @facebook-github-bot @cpuhrsch @albanD @drisspg