Skip to content

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Sep 26, 2022

Broken after #85597, i.e. https://github.com/pytorch/pytorch/actions/runs/3130970082

The workflow is not valid. .github/workflows/periodic.yml (Line: 189, Col: 26): Invalid secret, IOS_CERT_KEY_2022 is not defined in the referenced workflow. .github/workflows/periodic.yml (Line: 190, Col: 24): Invalid secret, IOS_CERT_SECRET is not defined in the referenced workflow.

@huydhn huydhn requested a review from a team as a code owner September 26, 2022 21:18
@huydhn huydhn self-assigned this Sep 26, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85664

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 3 Pending

As of commit 5bdf729:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 26, 2022
@huydhn huydhn added ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR and removed cla signed topic: not user facing topic category labels Sep 26, 2022
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come CI didn't catch that failure?

@huydhn
Copy link
Contributor Author

huydhn commented Sep 26, 2022

How come CI didn't catch that failure?

The change didn't have ciflow/periodic attached #85597, so this was missed completely during the PR

@huydhn
Copy link
Contributor Author

huydhn commented Sep 26, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@malfet
Copy link
Contributor

malfet commented Sep 26, 2022

@pytorchbot merge -f "It's already broken, so let's test in prod" :)

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: :)

usage: @pytorchbot [-h] {merge,revert,rebase,label} ...

Try @pytorchbot --help for more info.

@malfet
Copy link
Contributor

malfet commented Sep 26, 2022

@pytorchbot merge -f "It's already broken, so let's test in prod"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

Hey @huydhn.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
Broken after #85597, i.e. https://github.com/pytorch/pytorch/actions/runs/3130970082

```
The workflow is not valid. .github/workflows/periodic.yml (Line: 189, Col: 26): Invalid secret, IOS_CERT_KEY_2022 is not defined in the referenced workflow. .github/workflows/periodic.yml (Line: 190, Col: 24): Invalid secret, IOS_CERT_SECRET is not defined in the referenced workflow.
```

Pull Request resolved: #85664
Approved by: https://github.com/clee2000, https://github.com/kit1980, https://github.com/janeyx99, https://github.com/ZainRizvi, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants