-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Fix broken periodic workflow after removing ios secret #85664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85664
Note: Links to docs will display an error until the docs builds have been completed. ✅ No Failures, 3 PendingAs of commit 5bdf729: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come CI didn't catch that failure?
The change didn't have |
|
@pytorchbot merge -g |
|
@pytorchbot successfully started a merge job. Check the current status here. |
|
@pytorchbot merge -f "It's already broken, so let's test in prod" :) |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot merge -f "It's already broken, so let's test in prod" |
|
The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot. |
|
@pytorchbot successfully started a merge job. Check the current status here. |
|
Hey @huydhn. |
Broken after #85597, i.e. https://github.com/pytorch/pytorch/actions/runs/3130970082 ``` The workflow is not valid. .github/workflows/periodic.yml (Line: 189, Col: 26): Invalid secret, IOS_CERT_KEY_2022 is not defined in the referenced workflow. .github/workflows/periodic.yml (Line: 190, Col: 24): Invalid secret, IOS_CERT_SECRET is not defined in the referenced workflow. ``` Pull Request resolved: #85664 Approved by: https://github.com/clee2000, https://github.com/kit1980, https://github.com/janeyx99, https://github.com/ZainRizvi, https://github.com/malfet
Broken after #85597, i.e. https://github.com/pytorch/pytorch/actions/runs/3130970082