[functorch] refactor: get_exhaustive_batched_inputs #85965
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85965
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Failures, 2 PendingAs of commit fe71b30: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
CI failure looks unrelated (cuda out of memory) |
zou3519
approved these changes
Sep 30, 2022
|
@pytorchbot merge -f "CI failure unrelated (cuda oom)" |
|
@pytorchbot successfully started a merge job. Check the current status here. |
mehtanirav
pushed a commit
that referenced
this pull request
Oct 4, 2022
`get_exhaustive_batched_inputs_batch_norm_is_training` and `get_exhaustive_batched_inputs` are same except for a couple of lines. We move the above functionality into `generate_vmap_inputs` (which is now only function to create batched inputs) Pull Request resolved: #85965 Approved by: https://github.com/zou3519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_exhaustive_batched_inputs_batch_norm_is_trainingandget_exhaustive_batched_inputsare same except for a couple of lines.We move the above functionality into
generate_vmap_inputs(which is now only function to create batched inputs)