Skip to content

remove unused arg from impl_func_cum_ops #86364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

remove unused arg from impl_func_cum_ops #86364

wants to merge 1 commit into from

Conversation

@suprajb
Copy link
Contributor

@suprajb suprajb commented Oct 6, 2022

Fixes #86224

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 6, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86364

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures, 6 Pending

As of commit f01f2e4:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 6, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: suprajb / name: Supraj Bachawala (f01f2e4)

@bdhirsh bdhirsh self-requested a review October 6, 2022 22:32
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 6, 2022
@bdhirsh
Copy link
Contributor

bdhirsh commented Oct 6, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / macos-12-py3-arm64 / test (default, 1, 2, macos-m1-12)

Details for Dev Infra team Raised by workflow job

@bdhirsh
Copy link
Contributor

bdhirsh commented Oct 7, 2022

@pytorchbot merge -f "macOS test flaky, out of disk space"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Hey @suprajb.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

lezcano
lezcano reviewed Oct 7, 2022
View reviewed changes
aten/src/ATen/native/ReduceOps.cpp
TORCH_IMPL_FUNC(cumsum_out)
(const Tensor& self,
int64_t dim,
c10::optional<ScalarType> dtype,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that we don't need to remove the name. How come the linter is not complaining of an unused argument? @malfet

facebook-github-bot pushed a commit that referenced this pull request Oct 10, 2022
@suprajb @facebook-github-bot
remove unused arg from impl_func_cum_ops (#86364) (#86364)
8d12c85 
Summary:
Fixes #86224

Pull Request resolved: #86364
Approved by: https://github.com/bdhirsh

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/55f5e0de8dbd15d3732017796bddfa10fc76d033

Reviewed By: seemethere

Differential Revision: D40196975

Pulled By: seemethere

fbshipit-source-id: 1b47b1dc2a8682b2ed62127e343540d59f2233d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lezcano lezcano lezcano left review comments

@bdhirsh bdhirsh bdhirsh approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dtype arg in cumsum is passed around in the implementation, but it's not used.

5 participants

@suprajb @bdhirsh @pytorchmergebot @lezcano @pytorchbot