Skip to content

Changing from sample_inputs to reference_inputs in test_compare_cpu #86462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

Changing from sample_inputs to reference_inputs in test_compare_cpu #86462

wants to merge 15 commits into from

Conversation

srossross
Copy link
Collaborator

@srossross srossross commented Oct 7, 2022 •
edited
Loading

@srossross srossross mentioned this pull request Oct 7, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 7, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86462

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7a19898:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Oct 7, 2022
Closed
Closed
srossross added a commit that referenced this pull request Oct 7, 2022
@srossross
Changing from sample_inputs to reference_inputs in test_compare_cpu
40367dd 
ghstack-source-id: e0407ef
Pull Request resolved: #86462
srossross added a commit that referenced this pull request Oct 7, 2022
@srossross
Changing from sample_inputs to reference_inputs in test_compare_cpu
657f444 
ghstack-source-id: 33863f1
Pull Request resolved: #86462
srossross added a commit that referenced this pull request Oct 10, 2022
@srossross
Changing from sample_inputs to reference_inputs in test_compare_cpu
f00690e 
ghstack-source-id: a74238f
Pull Request resolved: #86462
srossross added a commit that referenced this pull request Oct 11, 2022
@srossross
Changing from sample_inputs to reference_inputs in test_compare_cpu
e4cbba9 
ghstack-source-id: f98be7e
Pull Request resolved: #86462
srossross added a commit that referenced this pull request Oct 12, 2022
@srossross
Changing from sample_inputs to reference_inputs in test_compare_cpu
976be50 
ghstack-source-id: bbe8371
Pull Request resolved: #86462
srossross added a commit that referenced this pull request Oct 13, 2022
@srossross
Changing from sample_inputs to reference_inputs in test_compare_cpu
647c035 
ghstack-source-id: 15bd308
Pull Request resolved: #86462
@srossross
Copy link
Collaborator Author

@lezcano can you take a look before I request a review?

lezcano
lezcano approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 17, 2022
@lezcano lezcano added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Oct 17, 2022
@srossross srossross marked this pull request as ready for review October 26, 2022 19:33
@github-actions
Copy link
Contributor

This PR needs a label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@srossross srossross added the topic: not user facing topic category label Oct 26, 2022
mruberry
mruberry approved these changes Oct 27, 2022
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool; nice comments for the new xfails.

@mruberry
Copy link
Collaborator

The ROCm failures look real:

2022-10-26T21:39:34.0129521Z ==================================== RERUNS ====================================
2022-10-26T21:39:34.0129823Z _____ TestCommonCUDA.test_compare_cpu__refs_bitwise_right_shift_cuda_int64 _____
2022-10-26T21:39:34.0130099Z Unexpected success
2022-10-26T21:39:34.0130386Z _____ TestCommonCUDA.test_compare_cpu__refs_bitwise_right_shift_cuda_int64 _____
2022-10-26T21:39:34.0130651Z Unexpected success
2022-10-26T21:39:34.0130867Z =================================== FAILURES ===================================
2022-10-26T21:39:34.0131163Z _____ TestCommonCUDA.test_compare_cpu__refs_bitwise_right_shift_cuda_int64 _____
2022-10-26T21:39:34.0131593Z Unexpected success

some of the xfails may need to become skips because CPUs are inconsistently consistent with CUDA

@srossross
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@srossross @kulinseth
Changing from sample_inputs to reference_inputs in test_compare_cpu (p…
3aab1bb 
…ytorch#86462)

Pull Request resolved: pytorch#86462
Approved by: https://github.com/lezcano, https://github.com/mruberry
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@srossross @kulinseth
Changing from sample_inputs to reference_inputs in test_compare_cpu (p…
28b421d 
…ytorch#86462)

Pull Request resolved: pytorch#86462
Approved by: https://github.com/lezcano, https://github.com/mruberry
@facebook-github-bot facebook-github-bot deleted the gh/srossross/8/head branch June 8, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lezcano lezcano lezcano approved these changes

@mruberry mruberry mruberry approved these changes

@ngimel ngimel Awaiting requested review from ngimel

Assignees

No one assigned

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@srossross @mruberry @pytorchmergebot @lezcano @pytorchbot