[primTorch] Check error_regex in test_python_ref_errors
#86987
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86987
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3475cd3: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
[ghstack-poisoned]
nkaretnikov
commented
Oct 24, 2022
[ghstack-poisoned]
nkaretnikov
commented
Oct 24, 2022
nkaretnikov
commented
Oct 25, 2022
| si = ei.sample_input | ||
| meta_sample = si.transform(_to_tensormeta) | ||
| # TODO: match strings | ||
| with self.assertRaisesRegex(ei.error_type, ""): |
There was a problem hiding this comment.
This is the main change, which required me to adjust everything else. Without this, strings of error inputs for refs are not checked. The other PRs re-enable testing for everything skipped in this PR.
nkaretnikov
requested review from
albanD,
jbschlosser,
mruberry and
ngimel
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
[ghstack-poisoned]
This was referenced Oct 26, 2022
[ghstack-poisoned]
[ghstack-poisoned]
|
@lezcano PTAL at the whole stack |
|
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
…86987) cc @ezyang @mruberry @ngimel @lezcano @fdrocha Pull Request resolved: pytorch#86987 Approved by: https://github.com/lezcano, https://github.com/mruberry
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…86987) cc @ezyang @mruberry @ngimel @lezcano @fdrocha Pull Request resolved: pytorch#86987 Approved by: https://github.com/lezcano, https://github.com/mruberry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
masked_fillref #87767catand related refs #87766error_regexintest_python_ref_errors#86987cc @ezyang @mruberry @ngimel @lezcano @fdrocha