Skip to content

Install blas from conda-forge #87150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Install blas from conda-forge #87150

wants to merge 3 commits into from

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Oct 17, 2022 •
edited
Loading

Mitigate #87148

Testing

On AWS (m1, linux)

  • Run conda install blas:openblas, it should failed with ChecksumMismatchError:
ChecksumMismatchError: Conda detected a mismatch between the expected content and downloaded content
for url 'https://repo.anaconda.com/pkgs/main/linux-64/blas-1.0-openblas.conda'.
  download saved to: /tmp/debug/pkgs/blas-1.0-openblas.conda
  expected sha256: c85b5d0a336b5be0f415c71fd7fe2eca59e09f42221bfa684aafef5510ba5487
  actual sha256: 5dc5483db0d9785b19e021cee418a8ee03e0ff0e5ebd0b75af4927746604e187
  • Run conda install -c conda-forge blas:openblas works

@huydhn huydhn self-assigned this Oct 17, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 17, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87150

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 Failures

As of commit 3a20b6c:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 17, 2022
@huydhn huydhn added ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request and removed topic: not user facing topic category labels Oct 17, 2022
@huydhn huydhn changed the title Use blas from conda-force Install blas from conda-force Oct 17, 2022
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 17, 2022
@huydhn huydhn marked this pull request as ready for review October 17, 2022 23:38
@huydhn huydhn requested a review from a team as a code owner October 17, 2022 23:38
@huydhn huydhn changed the title Install blas from conda-force Install blas from conda-forge Oct 17, 2022
@huydhn
Copy link
Contributor Author

huydhn commented Oct 17, 2022 •
edited
Loading

I'll let it run at least pass the install dependencies step before force merging this one

@clee2000
Copy link
Contributor

could you also change it here https://github.com/pytorch/pytorch/blob/master/.circleci/verbatim-sources/job-specs/job-specs-custom.yml#L580 for circleci

@huydhn
Copy link
Contributor Author

huydhn commented Oct 17, 2022 •
edited
Loading

could you also change it here https://github.com/pytorch/pytorch/blob/master/.circleci/verbatim-sources/job-specs/job-specs-custom.yml#L580 for circleci

Hmm, is this also failing for circle CI? But yeah I could include this as well

@huydhn
Copy link
Contributor Author

huydhn commented Oct 18, 2022

@pytorchbot merge -f 'Lint has passed. Jobs have gone passed conda installation step https://github.com/pytorch/pytorch/actions/runs/3269534431/jobs/5377144914, force merge this to fix trunk. Fingers crossed'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor

malfet commented Oct 18, 2022

Please note, that using conda-forge is dangerous, we should not rely on it by default...

@huydhn huydhn deleted the use-conda-forge branch October 18, 2022 00:56
@huydhn huydhn mentioned this pull request Oct 18, 2022
Closed
@huydhn
Copy link
Contributor Author

huydhn commented Oct 18, 2022

Please note, that using conda-forge is dangerous, we should not rely on it by default...

Noted. Once the issue is mitigated upstream anaconda/anaconda-client#622, I will revert this change

pytorchmergebot pushed a commit that referenced this pull request Oct 18, 2022
@huydhn @pytorchmergebot
Use conda-forge in mac mps test (#87155)
74138a8 
#87150 works, most of the jobs are ok now.  However, I miss one last piece in MPS test workflow https://github.com/pytorch/pytorch/actions/runs/3269594289/jobs/5377469209.  So this fixes the missing piece to use conda-forge

Pull Request resolved: #87155
Approved by: https://github.com/kit1980, https://github.com/ZainRizvi
@huydhn huydhn mentioned this pull request Oct 18, 2022
Closed
huydhn added a commit to huydhn/pytorch that referenced this pull request Oct 18, 2022
@huydhn
Revert "Install blas from conda-forge (pytorch#87150)"
303ac38 
This reverts commit f02f0e3.
ZainRizvi pushed a commit that referenced this pull request Oct 18, 2022
@huydhn @ZainRizvi
Install blas from conda-forge (#87150)
ae8a80f 
Mitigate #87148

### Testing

On AWS (m1, linux)

* Run `conda install blas:openblas`, it should failed with `ChecksumMismatchError`:

```
ChecksumMismatchError: Conda detected a mismatch between the expected content and downloaded content
for url 'https://repo.anaconda.com/pkgs/main/linux-64/blas-1.0-openblas.conda'.
  download saved to: /tmp/debug/pkgs/blas-1.0-openblas.conda
  expected sha256: c85b5d0a336b5be0f415c71fd7fe2eca59e09f42221bfa684aafef5510ba5487
  actual sha256: 5dc5483db0d9785b19e021cee418a8ee03e0ff0e5ebd0b75af4927746604e187
```

* Run ` conda install -c conda-forge blas:openblas` works

Pull Request resolved: #87150
Approved by: https://github.com/kit1980
ZainRizvi pushed a commit that referenced this pull request Oct 18, 2022
@huydhn @ZainRizvi
Use conda-forge in mac mps test (#87155)
94fdc35 
#87150 works, most of the jobs are ok now.  However, I miss one last piece in MPS test workflow https://github.com/pytorch/pytorch/actions/runs/3269594289/jobs/5377469209.  So this fixes the missing piece to use conda-forge

Pull Request resolved: #87155
Approved by: https://github.com/kit1980, https://github.com/ZainRizvi
@huydhn
Copy link
Contributor Author

huydhn commented Oct 18, 2022

@pytorchbot revert -m 'Conda issue has been resolved upstream #87148' -c weird

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@huydhn your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Oct 18, 2022
@pytorchmergebot
Revert "Install blas from conda-forge (#87150)"
afa5086 
This reverts commit f02f0e3.

Reverted #87150 on behalf of https://github.com/huydhn due to Conda issue has been resolved upstream #87148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@huydhn huydhn

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@huydhn @clee2000 @pytorchmergebot @malfet @kit1980