[functorch] Get rid of defunct functorch/setup.py #87235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We initially left it there for BC concerns. - It has been more than a month since then, - I have migrated folks who used the previous install command (pip install ...pytorch.git@subdir=functorch) off of it so it's time to get rid of it Test Plan: - code reading [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87235
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Failures, 1 PendingAs of commit 0d26d72: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zou3519
added a commit
that referenced
this pull request
Oct 18, 2022
We initially left it there for BC concerns. - It has been more than a month since then, - I have migrated folks who used the previous install command (pip install ...pytorch.gitsubdir=functorch) off of it so it's time to get rid of it Test Plan: - code reading ghstack-source-id: ad57a80 Pull Request resolved: #87235
Chillee
approved these changes
Oct 18, 2022
|
@pytorchbot merge -f "failures look unrelated" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We initially left it there for BC concerns.
install ...pytorch.git@subdir=functorch) off of it
so it's time to get rid of it
Test Plan: