-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[ao] Adding FAQ to docs #87322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ao] Adding FAQ to docs #87322
Conversation
Summary: migrated from: https://discuss.pytorch.org/t/quantization-frequently-asked-questions/161251 Test Plan: circle CI tests Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87322
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 40f6ae0: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: migrated from: https://discuss.pytorch.org/t/quantization-frequently-asked-questions/161251 Test Plan: circle CI tests Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 9ad07a4 Pull Request resolved: #87322
Summary: migrated from: https://discuss.pytorch.org/t/quantization-frequently-asked-questions/161251 Test Plan: circle CI tests Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can always add more items here, if some questions keep on popping up
docs/source/quantization.rst
Outdated
| Supporting export to onnx model is not a priority for PyTorch quantization, please open an issue in `GitHub - onnx/onnx <https://github.com/onnx/onnx>`_ when you encounter problems with ONNX, | ||
| or reach out to people in this list: `PyTorch Governance | Maintainers | ONNX exporter <https://pytorch.org/docs/stable/community/persons_of_interest.html#onnx-exporter>`_ | ||
|
|
||
| 3. How can use quantization with LSTM's?: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Is a word missing? Seems awkward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
docs/source/quantization.rst
Outdated
|
|
||
| 2. Where can I get ONNX support for my quantized model?: | ||
|
|
||
| Supporting export to onnx model is not a priority for PyTorch quantization, please open an issue in `GitHub - onnx/onnx <https://github.com/onnx/onnx>`_ when you encounter problems with ONNX, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: IMHO, saying that it's not a priority sounds a little dismissive. Could we reword it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i've changed the language to omit that part
Summary: migrated from: https://discuss.pytorch.org/t/quantization-frequently-asked-questions/161251 Test Plan: circle CI tests Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: migrated from: https://discuss.pytorch.org/t/quantization-frequently-asked-questions/161251 Test Plan: circle CI tests Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: migrated from: https://discuss.pytorch.org/t/quantization-frequently-asked-questions/161251 Test Plan: circle CI tests Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: migrated from: https://discuss.pytorch.org/t/quantization-frequently-asked-questions/161251 Test Plan: circle CI tests Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 4c130ca Pull Request resolved: #87322
Summary: migrated from: https://discuss.pytorch.org/t/quantization-frequently-asked-questions/161251 Test Plan: circle CI tests Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: migrated from: https://discuss.pytorch.org/t/quantization-frequently-asked-questions/161251 Test Plan: circle CI tests Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 7f714c6 Pull Request resolved: #87322
Summary: migrated from: https://discuss.pytorch.org/t/quantization-frequently-asked-questions/161251 Test Plan: circle CI tests Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: migrated from: https://discuss.pytorch.org/t/quantization-frequently-asked-questions/161251 Test Plan: circle CI tests Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: d76cb12 Pull Request resolved: #87322
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 additional jobs have failed, first few of them are: trunk Details for Dev Infra teamRaised by workflow job |
Summary: migrated from: https://discuss.pytorch.org/t/quantization-frequently-asked-questions/161251 Test Plan: circle CI tests Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: migrated from: https://discuss.pytorch.org/t/quantization-frequently-asked-questions/161251 Test Plan: circle CI tests Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 8893b9f Pull Request resolved: #87322
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: migrated from: https://discuss.pytorch.org/t/quantization-frequently-asked-questions/161251 Test Plan: circle CI tests Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: pytorch#87322 Approved by: https://github.com/z-a-f
Summary: migrated from: https://discuss.pytorch.org/t/quantization-frequently-asked-questions/161251 Test Plan: circle CI tests Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: pytorch#87322 Approved by: https://github.com/z-a-f
Stack from ghstack (oldest at bottom):
Summary: migrated from: https://discuss.pytorch.org/t/quantization-frequently-asked-questions/161251
Test Plan: circle CI tests
Reviewers:
Subscribers:
Tasks:
Tags: