Skip to content

set ci in mps #87325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Add extra debug info for the super common "index out of bounds" error.
wants to merge 3 commits into from
Closed

set ci in mps #87325

wants to merge 3 commits into from

Conversation

@clee2000
Copy link
Contributor

@clee2000 clee2000 commented Oct 19, 2022 •
edited
Loading

dunno if installing xml runner like this is a good idea

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 19, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 19, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87325

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f2af3f4:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@clee2000 clee2000 added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 19, 2022
@clee2000 clee2000 marked this pull request as ready for review October 20, 2022 16:35
@clee2000 clee2000 requested a review from a team as a code owner October 20, 2022 16:35
huydhn
huydhn approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok for now if you need it to fix CI issue. I'm in the middle of moving all similar usages (line 53-54) to a one place. So there might be some refactoring later on in mac and mps workflows

@clee2000
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@clee2000 clee2000 mentioned this pull request Nov 12, 2022
Closed
@github-actions github-actions bot deleted the csl/cimps branch April 20, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@clee2000 @pytorchmergebot @huydhn @malfet