-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Remove unused cold_start experiment #87470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- this `--cold_start` experiment didn't end up being used - there is a new `--cold_start_latency` flag that is used - this experiment was only hooked up for nvfuser anyway [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87470
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Failures, 1 PendingAs of commit df1c6bc: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
- this `--cold_start` experiment didn't end up being used - there is a new `--cold_start_latency` flag that is used - this experiment was only hooked up for nvfuser anyway cc jansel lezcano fdrocha mlazos soumith voznesenskym yanboliang [ghstack-poisoned]
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 additional jobs have failed, first few of them are: trunk ,trunk / cuda11.6-py3.10-gcc7-sm86 / test (default, 1, 4, linux.g5.4xlarge.nvidia.gpu) Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge -f "CI is broken, but this is low risk" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Hey @wconstab. |
- this `--cold_start` experiment didn't end up being used - there is a new `--cold_start_latency` flag that is used - this experiment was only hooked up for nvfuser anyway cc @jansel @lezcano @fdrocha @mlazos @soumith @voznesenskym @yanboliang Pull Request resolved: pytorch#87470 Approved by: https://github.com/anijain2305
- this `--cold_start` experiment didn't end up being used - there is a new `--cold_start_latency` flag that is used - this experiment was only hooked up for nvfuser anyway cc @jansel @lezcano @fdrocha @mlazos @soumith @voznesenskym @yanboliang Pull Request resolved: pytorch#87470 Approved by: https://github.com/anijain2305
Stack from ghstack (oldest at bottom):
--cold_start
experiment didn't end up being used--cold_start_latency
flag that is usedcc @jansel @lezcano @fdrocha @mlazos @soumith @voznesenskym @yanboliang