Only label checks against pull requests #87488
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huydhn
approved these changes
Oct 21, 2022
|
@pytorchbot merge -f "Linter passes and the Check Labels check passes correctly" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
When a commit is triggered via any mechanism other than a pull request, there will not be a PR to check labels for. The job will fail with the error: ``` 2022-10-21T17:50:53.2938592Z + python3 .github/scripts/check_labels.py '' 2022-10-21T17:50:53.4758863Z usage: Check PR labels [-h] pr_num 2022-10-21T17:50:53.4759337Z Check PR labels: error: argument pr_num: invalid int value: '' ``` Instead, we should limit the workflow to only run on pull requests Pull Request resolved: pytorch#87488 Approved by: https://github.com/huydhn
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
When a commit is triggered via any mechanism other than a pull request, there will not be a PR to check labels for. The job will fail with the error: ``` 2022-10-21T17:50:53.2938592Z + python3 .github/scripts/check_labels.py '' 2022-10-21T17:50:53.4758863Z usage: Check PR labels [-h] pr_num 2022-10-21T17:50:53.4759337Z Check PR labels: error: argument pr_num: invalid int value: '' ``` Instead, we should limit the workflow to only run on pull requests Pull Request resolved: pytorch#87488 Approved by: https://github.com/huydhn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a commit is triggered via any mechanism other than a pull request, there will not be a PR to check labels for.
The job will fail with the error:
Instead, we should limit the workflow to only run on pull requests