Skip to content

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Oct 26, 2022

current output tends to be empty on failure, which makes it hard to debug

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 26, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 26, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87795

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 1 Pending

As of commit 2fecb64:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@clee2000 clee2000 marked this pull request as ready for review October 26, 2022 16:35
@clee2000 clee2000 requested a review from a team as a code owner October 26, 2022 16:35
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Btw the rebase job https://github.com/pytorch/pytorch/actions/runs/3325977949/jobs/5499220794 was green, so python3 .github/scripts/tryrebase.py must have finish successfully with exit 0. I wonder if the script shallow the error somehow. I mean the raise Exception(f"\n```{push_result}```") one line 73. Or it might not be the case here, but let's find out

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 26, 2022
@clee2000
Copy link
Contributor Author

it shows up as green b/c the exception is caught and a comment is posted using the exception

@clee2000
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
current output tends to be empty on failure, which makes it hard to debug
Pull Request resolved: pytorch#87795
Approved by: https://github.com/huydhn, https://github.com/ZainRizvi
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
current output tends to be empty on failure, which makes it hard to debug
Pull Request resolved: pytorch#87795
Approved by: https://github.com/huydhn, https://github.com/ZainRizvi
@github-actions github-actions bot deleted the csl/easyrebase branch April 27, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants