Skip to content

[BE] Use default constructor in LoggerVoidify #88054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Add extra debug info for the super common "index out of bounds" error.
wants to merge 1 commit into from
Closed

[BE] Use default constructor in LoggerVoidify #88054

wants to merge 1 commit into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Oct 30, 2022

No description provided.

@malfet malfet requested a review from a team October 30, 2022 19:18
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 30, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88054

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures, 1 Pending

As of commit c306cc4:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link
Contributor

This PR needs a label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@malfet malfet added the topic: not user facing topic category label Oct 30, 2022
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 30, 2022
@malfet
Copy link
Contributor Author

malfet commented Nov 1, 2022

@pytorchbot merge -f "Distributed failure is unrelated"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet deleted the malfet-patch-21 branch November 4, 2022 04:30
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@malfet @kulinseth
[BE] Use default constructor in LoggerVoidify (pytorch#88054)
9bd1875 
Pull Request resolved: pytorch#88054
Approved by: https://github.com/kit1980
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@malfet @kulinseth
[BE] Use default constructor in LoggerVoidify (pytorch#88054)
82e620c 
Pull Request resolved: pytorch#88054
Approved by: https://github.com/kit1980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malfet @pytorchmergebot @kit1980