[Pytorch][Vulkan] Update spv generation script to embed shader parameters #88321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters This diffs adds shader parameters such as tile size, weight storage type and format to the generated spv.cpp file. This is used in ShaderInfo struct that ops such as convolution will use to determine, the workgroup size and how to pack weights. Differential Revision: [D40280337](https://our.internmc.facebook.com/intern/diff/D40280337/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88321
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit dd7c2fc: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 2, 2022
jmdetloff
approved these changes
Nov 2, 2022
mcr229
approved these changes
Nov 2, 2022
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
…ters (pytorch#88321) This diffs adds shader parameters such as tile size, weight storage type and format to the generated spv.cpp file. This is used in ShaderInfo struct that ops such as convolution will use to determine, the workgroup size and how to pack weights. Differential Revision: [D40280337](https://our.internmc.facebook.com/intern/diff/D40280337/) Pull Request resolved: pytorch#88321 Approved by: https://github.com/jmdetloff, https://github.com/mcr229
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…ters (pytorch#88321) This diffs adds shader parameters such as tile size, weight storage type and format to the generated spv.cpp file. This is used in ShaderInfo struct that ops such as convolution will use to determine, the workgroup size and how to pack weights. Differential Revision: [D40280337](https://our.internmc.facebook.com/intern/diff/D40280337/) Pull Request resolved: pytorch#88321 Approved by: https://github.com/jmdetloff, https://github.com/mcr229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diffs adds shader parameters such as tile size, weight storage type and
format to the generated spv.cpp file.
This is used in ShaderInfo struct that ops such as convolution will use to
determine, the workgroup size and how to pack weights.
Differential Revision: D40280337