[export] Preserve meta["val"] on placeholders in dynamo.export(). #88651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88651
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bd31fc0: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D41110864 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D41110864 |
zhxchen17
force-pushed
the
export-D41110864
branch
from
86a0202 to
d3036de
Compare
tugsbayasgalan
approved these changes
Nov 8, 2022
zhxchen17
force-pushed
the
export-D41110864
branch
from
d3036de to
ca1da55
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41110864 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D41110864 |
zhxchen17
force-pushed
the
export-D41110864
branch
from
ca1da55 to
2187f57
Compare
jansel
approved these changes
Nov 8, 2022
…torch#88651) Summary: Pull Request resolved: pytorch#88651 Today when we transform the captured graph in the last step in export(aten_graph=True), we construct a new graph which doesn't have the all the metadata to be preserved, for example, node.meta["val"]. meta["val"] is important for writing passes and analysis on the graph later in the pipeline, we may want to preserve that on placeholder nodes. Test Plan: test_export.py:test_export_meta_val Reviewed By: tugsbayasgalan Differential Revision: D41110864 fbshipit-source-id: da299653d311078e555a028c534c43c817165266
|
This pull request was exported from Phabricator. Differential Revision: D41110864 |
zhxchen17
force-pushed
the
export-D41110864
branch
from
2187f57 to
bd31fc0
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…torch#88651) Summary: Today when we transform the captured graph in the last step in export(aten_graph=True), we construct a new graph which doesn't have the all the metadata to be preserved, for example, node.meta["val"]. meta["val"] is important for writing passes and analysis on the graph later in the pipeline, we may want to preserve that on placeholder nodes. Test Plan: test_export.py:test_export_meta_val Differential Revision: D41110864 Pull Request resolved: pytorch#88651 Approved by: https://github.com/tugsbayasgalan, https://github.com/jansel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Today when we transform the captured graph in the last step in export(aten_graph=True), we construct a new graph which doesn't have the all the metadata to be preserved, for example, node.meta["val"].
meta["val"] is important for writing passes and analysis on the graph later in the pipeline, we may want to preserve that on placeholder nodes.
Test Plan: test_export.py:test_export_meta_val
Differential Revision: D41110864
cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire