Skip to content

[Dynamo] Add a dummy profiler to avoid activating real profiler #88930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[Dynamo] Add a dummy profiler to avoid activating real profiler #88930

wants to merge 3 commits into from

Conversation

@yanboliang
Copy link
Contributor

@yanboliang yanboliang commented Nov 12, 2022 •
edited by pytorch-bot bot
Loading

@yanboliang yanboliang requested a review from robieta as a code owner November 12, 2022 07:18
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 12, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88930

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9eacfde:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jansel
jansel approved these changes Nov 14, 2022
View reviewed changes
yuguo68
yuguo68 reviewed Nov 14, 2022
View reviewed changes
@yanboliang
Copy link
Contributor Author

Thank you for reminding me of contextlib.nullcontext, I decided to switch to that. It'll be easily used for other context managers we don't support yet, e.g, with torch.backends.cudnn.flags(#93586).

yuguo68
yuguo68 reviewed Nov 15, 2022
View reviewed changes
@yanboliang
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 15, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / macos-12-py3-arm64 / test (default, 1, 2, macos-m1-12)

Details for Dev Infra team Raised by workflow job

@yanboliang
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@yanboliang yanboliang deleted the prof branch November 16, 2022 19:15
@yanboliang yanboliang mentioned this pull request Nov 16, 2022
Closed
3 tasks
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@yanboliang @kulinseth
[Dynamo] Add a dummy profiler to avoid activating real profiler (pyto…
c8f3dd2 
…rch#88930)

See context at pytorch/torchdynamo#1721 (comment)

Pull Request resolved: pytorch#88930
Approved by: https://github.com/jansel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuguo68 yuguo68 yuguo68 left review comments

@jansel jansel jansel approved these changes

@robieta robieta Awaiting requested review from robieta

@anijain2305 anijain2305 Awaiting requested review from anijain2305

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yanboliang @pytorchmergebot @jansel @yuguo68