Skip to content

[3/n] Thread PG: add scatter to threaded pg #89441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[3/n] Thread PG: add scatter to threaded pg #89441

wants to merge 2 commits into from

Conversation

@wanchaol
Copy link
Collaborator

@wanchaol wanchaol commented Nov 21, 2022 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 21, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89441

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 28a1d3d:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Nov 21, 2022
Closed
Closed
Closed
Closed
@wanchaol wanchaol added the topic: not user facing topic category label Nov 21, 2022
XilunWu
XilunWu approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@XilunWu XilunWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. waiting for CI.

yhcharles
yhcharles approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@yhcharles yhcharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pytorchmergebot
Copy link
Collaborator

Rebased gh/wanchaol/217/orig onto refs/remotes/origin/viable/strict because #89443 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/89441)

fduwjj
fduwjj approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@wanchaol @kulinseth
[3/n] Thread PG: add scatter to threaded pg (pytorch#89441)
8758604 
Pull Request resolved: pytorch#89441
Approved by: https://github.com/XilunWu, https://github.com/yhcharles, https://github.com/fduwjj
@facebook-github-bot facebook-github-bot deleted the gh/wanchaol/215/head branch June 8, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fduwjj fduwjj fduwjj approved these changes

@XilunWu XilunWu XilunWu approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

+1 more reviewer

@yhcharles yhcharles yhcharles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wanchaol @pytorchmergebot @yhcharles @fduwjj @XilunWu