[PyTorch Edge] Set training for module only #89488
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update previous recursive logic. Continue setting training attribute only if the slot is an object and a module. For the corresponding JIT module, they get the module list first and set module one by one. there is method to get all modules iteratively, instead of recursively. This change patch one fix to set training attribute for `model_f269583363.ptl`. Another patch is needed, because current lite interpreter doesn't have the correct type when loading object with setstate. Differential Revision: [D41466417](https://our.internmc.facebook.com/intern/diff/D41466417/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89488
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 03d89cd: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cccclai
added a commit
that referenced
this pull request
Nov 22, 2022
Update previous recursive logic. Continue setting training attribute only if the slot is an object and a module. For the corresponding JIT module, they get the module list first and set module one by one. there is method to get all modules iteratively, instead of recursively. This change patch one fix to set training attribute for `model_f269583363.ptl`. Another patch is needed, because current lite interpreter doesn't have the correct type when loading object with setstate. Differential Revision: [D41466417](https://our.internmc.facebook.com/intern/diff/D41466417/) ghstack-source-id: 174195645 Pull Request resolved: #89488
Update previous recursive logic. Continue setting training attribute only if the slot is an object and a module. For the corresponding JIT module, they get the module list first and set module one by one. there is method to get all modules iteratively, instead of recursively. This change patch one fix to set training attribute for `model_f269583363.ptl`. Another patch is needed, because current lite interpreter doesn't have the correct type when loading object with setstate. Differential Revision: [D41466417](https://our.internmc.facebook.com/intern/diff/D41466417/) [ghstack-poisoned]
cccclai
added a commit
that referenced
this pull request
Nov 22, 2022
Pull Request resolved: #89488 Update previous recursive logic. Continue setting training attribute only if the slot is an object and a module. For the corresponding JIT module, they get the module list first and set module one by one. there is method to get all modules iteratively, instead of recursively. This change patch one fix to set training attribute for `model_f269583363.ptl`. Another patch is needed, because current lite interpreter doesn't have the correct type when loading object with setstate. ghstack-source-id: 174243857 Differential Revision: [D41466417](https://our.internmc.facebook.com/intern/diff/D41466417/)
Update previous recursive logic. Continue setting training attribute only if the slot is an object and a module. For the corresponding JIT module, they get the module list first and set module one by one. there is method to get all modules iteratively, instead of recursively. This change patch one fix to set training attribute for `model_f269583363.ptl`. Another patch is needed, because current lite interpreter doesn't have the correct type when loading object with setstate. Differential Revision: [D41466417](https://our.internmc.facebook.com/intern/diff/D41466417/) [ghstack-poisoned]
Update previous recursive logic. Continue setting training attribute only if the slot is an object and a module. For the corresponding JIT module, they get the module list first and set module one by one. there is method to get all modules iteratively, instead of recursively. This change patch one fix to set training attribute for `model_f269583363.ptl`. Another patch is needed, because current lite interpreter doesn't have the correct type when loading object with setstate. Differential Revision: [D41466417](https://our.internmc.facebook.com/intern/diff/D41466417/) [ghstack-poisoned]
cccclai
added a commit
that referenced
this pull request
Nov 29, 2022
Pull Request resolved: #89488 Update previous recursive logic. Continue setting training attribute only if the slot is an object and a module. For the corresponding JIT module, they get the module list first and set module one by one. there is method to get all modules iteratively, instead of recursively. This change patch one fix to set training attribute for `model_f269583363.ptl`. Another patch is needed, because current lite interpreter doesn't have the correct type when loading object with setstate. ghstack-source-id: 174538868 Differential Revision: [D41466417](https://our.internmc.facebook.com/intern/diff/D41466417/)
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Update previous recursive logic. Continue setting training attribute only if the slot is an object and a module. For the corresponding JIT module, they get the module list first and set module one by one. there is method to get all modules iteratively, instead of recursively. This change patch one fix to set training attribute for `model_f269583363.ptl`. Another patch is needed, because current lite interpreter doesn't have the correct type when loading object with setstate. Differential Revision: [D41466417](https://our.internmc.facebook.com/intern/diff/D41466417/) Pull Request resolved: pytorch#89488 Approved by: https://github.com/iseeyuan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Update previous recursive logic.
Continue setting training attribute only if the slot is an object and a module.
For the corresponding JIT module, they get the module list first and set module one by one. there is method to get all modules iteratively, instead of recursively.
This change patch one fix to set training attribute for
model_f269583363.ptl. Another patch is needed, because current lite interpreter doesn't have the correct type when loading object with setstate.Differential Revision: D41466417